From 006a37d2686a8f44c20a1291d50c70581c95b3f7 Mon Sep 17 00:00:00 2001 From: Nick Todd Date: Wed, 22 Nov 2023 14:40:44 +0000 Subject: [PATCH] #2042: extract code into request_time() method. --- .../simulator/system/services/ntp/ntp_client.py | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/primaite/simulator/system/services/ntp/ntp_client.py b/src/primaite/simulator/system/services/ntp/ntp_client.py index 51df5010..38ef820b 100644 --- a/src/primaite/simulator/system/services/ntp/ntp_client.py +++ b/src/primaite/simulator/system/services/ntp/ntp_client.py @@ -93,10 +93,19 @@ class NTPClient(Service): _LOGGER.debug(f"{payload} is not a NTPPacket") return False if payload.ntp_reply.ntp_datetime: - self.sys_log.info(f"{self.name}: Received time update from NTP server{payload.ntp_reply.ntp_datetime}") + self.sys_log.info( + f"{self.name}: \ + Received time update from NTP server{payload.ntp_reply.ntp_datetime}" + ) self.time = payload.ntp_reply.ntp_datetime return True + def request_time(self) -> None: + """Send request to ntp_server.""" + ntp_request = NTPRequest(ntp_client=self.ip_addr) + ntp_server_packet = NTPPacket(ntp_request=ntp_request) + self.send(payload=ntp_server_packet) + def apply_timestep(self, timestep: int) -> None: """ For each timestep request the time from the NTP server. @@ -112,8 +121,6 @@ class NTPClient(Service): super().apply_timestep(timestep) if self.operating_state == ServiceOperatingState.RUNNING: # request time from server - ntp_request = NTPRequest(ntp_client=self.ip_addr) - ntp_server_packet = NTPPacket(ntp_request=ntp_request) - self.send(payload=ntp_server_packet) + self.request_time() else: self.sys_log.debug(f"{self.name} ntp client not running")