diff --git a/benchmark/report.py b/benchmark/report.py index 9c576562..5eaaab9f 100644 --- a/benchmark/report.py +++ b/benchmark/report.py @@ -17,8 +17,6 @@ PLOT_CONFIG = { "size": {"auto_size": False, "width": 1500, "height": 900}, "template": "plotly_white", "range_slider": False, - "av_s_per_100_steps_10_nodes_benchmark_threshold": 5, - "benchmark_line_color": "grey", } @@ -229,10 +227,7 @@ def _plot_av_s_per_100_steps_10_nodes( """ Creates a bar chart visualising the performance of each version of PrimAITE. - Performance is based on the average training time per 100 steps on 10 nodes. The function also includes a benchmark - line indicating the target maximum time. - - Versions that perform under this time are marked in green, and those over are marked in red. + Performance is based on the average training time per 100 steps on 10 nodes. :param version_times_dict: A dictionary with software versions as keys and average times as values. :return: A Plotly figure object representing the bar chart of the performance metrics. @@ -256,7 +251,6 @@ def _plot_av_s_per_100_steps_10_nodes( versions = sorted(list(version_times_dict.keys())) times = [version_times_dict[version] for version in versions] av_s_per_100_steps_10_nodes_benchmark_threshold = PLOT_CONFIG["av_s_per_100_steps_10_nodes_benchmark_threshold"] - benchmark_line_color = PLOT_CONFIG["benchmark_line_color"] # Calculate the appropriate maximum y-axis value max_y_axis_value = max(max(times), av_s_per_100_steps_10_nodes_benchmark_threshold) + 1 @@ -265,28 +259,11 @@ def _plot_av_s_per_100_steps_10_nodes( go.Bar( x=versions, y=times, - marker_color=[ - "green" if time < av_s_per_100_steps_10_nodes_benchmark_threshold else "red" for time in times - ], text=times, textposition="auto", ) ) - # Add a horizontal line for the benchmark - fig.add_shape( - type="line", - x0=-0.5, # start slightly before the first bar - x1=len(versions) - 0.5, # end slightly after the last bar - y0=av_s_per_100_steps_10_nodes_benchmark_threshold, - y1=av_s_per_100_steps_10_nodes_benchmark_threshold, - line=dict( - color=benchmark_line_color, - width=2, - dash="dot", - ), - ) - fig.update_layout( xaxis_title="PrimAITE Version", yaxis_title="Avg Time per 100 Steps on 10 Nodes (seconds)", diff --git a/benchmark/results/v3/v3.0.0/PrimAITE Performance of Minor and Bugfix Releases for Major Version 3.png b/benchmark/results/v3/v3.0.0/PrimAITE Performance of Minor and Bugfix Releases for Major Version 3.png index 05fa4f15..cd19c945 100644 Binary files a/benchmark/results/v3/v3.0.0/PrimAITE Performance of Minor and Bugfix Releases for Major Version 3.png and b/benchmark/results/v3/v3.0.0/PrimAITE Performance of Minor and Bugfix Releases for Major Version 3.png differ diff --git a/benchmark/results/v3/v3.1.0/PrimAITE Performance of Minor and Bugfix Releases for Major Version 3.png b/benchmark/results/v3/v3.1.0/PrimAITE Performance of Minor and Bugfix Releases for Major Version 3.png index 29036db5..6d61d47f 100644 Binary files a/benchmark/results/v3/v3.1.0/PrimAITE Performance of Minor and Bugfix Releases for Major Version 3.png and b/benchmark/results/v3/v3.1.0/PrimAITE Performance of Minor and Bugfix Releases for Major Version 3.png differ diff --git a/benchmark/results/v3/v3.2.0/PrimAITE Performance of Minor and Bugfix Releases for Major Version 3.png b/benchmark/results/v3/v3.2.0/PrimAITE Performance of Minor and Bugfix Releases for Major Version 3.png index 665525e8..40f29d7b 100644 Binary files a/benchmark/results/v3/v3.2.0/PrimAITE Performance of Minor and Bugfix Releases for Major Version 3.png and b/benchmark/results/v3/v3.2.0/PrimAITE Performance of Minor and Bugfix Releases for Major Version 3.png differ