oxbrbtx/PrimAITE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

#2777: Code review changes.

Browse Source
This commit is contained in:
Nick Todd
2024-08-05 17:45:01 +01:00
parent 3253dd8054
commit 3441dd2509
3 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@@ -6,7 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [Unreleased] ## [Unreleased]
### Added
- Random Number Generator Seeding by specifying a random number seed in the config file.
### Changed ### Changed
- Removed the install/uninstall methods in the node class and made the software manager install/uninstall handle all of their functionality. - Removed the install/uninstall methods in the node class and made the software manager install/uninstall handle all of their functionality.
@@ -22,7 +23,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Tests to verify that airspace bandwidth is applied correctly and can be configured via YAML - Tests to verify that airspace bandwidth is applied correctly and can be configured via YAML
- Agent logging for agents' internal decision logic - Agent logging for agents' internal decision logic
- Action masking in all PrimAITE environments - Action masking in all PrimAITE environments
- Random Number Generator Seeding by specifying a random number seed in the config file.
### Changed ### Changed
- Application registry was moved to the `Application` class and now updates automatically when Application is subclassed - Application registry was moved to the `Application` class and now updates automatically when Application is subclassed
- Databases can no longer respond to request while performing a backup - Databases can no longer respond to request while performing a backup

2
src/primaite/game/agent/scripted_agents/probabilistic_agent.py
View File

@@ -68,7 +68,7 @@ class ProbabilisticAgent(AbstractScriptedAgent):
self.probabilities = np.asarray(list(self.settings.action_probabilities.values())) self.probabilities = np.asarray(list(self.settings.action_probabilities.values()))
super().__init__(agent_name, action_space, observation_space, reward_function) super().__init__(agent_name, action_space, observation_space, reward_function)
self.logger.info(f"ProbabilisticAgent RNG seed: {rng_seed}") self.logger.debug(f"ProbabilisticAgent RNG seed: {rng_seed}")
def get_action(self, obs: ObsType, timestep: int = 0) -> Tuple[str, Dict]: def get_action(self, obs: ObsType, timestep: int = 0) -> Tuple[str, Dict]:
""" """

7
src/primaite/session/environment.py
View File

@@ -44,9 +44,8 @@ def set_random_seed(seed: int) -> Union[None, int]:
# if torch not installed don't set random seed. # if torch not installed don't set random seed.
if sys.modules["torch"]: if sys.modules["torch"]:
th.manual_seed(seed) th.manual_seed(seed)
th.backends.cudnn.deterministic = True
th.backends.cudnn.deterministic = True th.backends.cudnn.benchmark = False
th.backends.cudnn.benchmark = False
return seed return seed
@@ -64,7 +63,7 @@ class PrimaiteGymEnv(gymnasium.Env):
super().__init__() super().__init__()
self.episode_scheduler: EpisodeScheduler = build_scheduler(env_config) self.episode_scheduler: EpisodeScheduler = build_scheduler(env_config)
"""Object that returns a config corresponding to the current episode.""" """Object that returns a config corresponding to the current episode."""
self.seed = self.episode_scheduler(0).get("game").get("seed") self.seed = self.episode_scheduler(0).get("game", {}).get("seed")
"""Get RNG seed from config file. NB: Must be before game instantiation.""" """Get RNG seed from config file. NB: Must be before game instantiation."""
self.seed = set_random_seed(self.seed) self.seed = set_random_seed(self.seed)
self.io = PrimaiteIO.from_config(self.episode_scheduler(0).get("io_settings", {})) self.io = PrimaiteIO.from_config(self.episode_scheduler(0).get("io_settings", {}))