#1355 - Carried out full renaming in node.py, active_node.py, passive_node.py, and service_node.py to make params and variable names explicit.

- Made the same renaming in the yaml laydown config files.
- Added Type hints wherever I've been.
- Added a custom NodeType in custom_typing.py to encompass the Union of ActiveNode, PassiveNode, ServiceNode.

tests/config/one_node_states_on_off_lay_down_config.yaml

@@ -9,15 +9,15 @@
   serviceList:
   - name: ftp
 - itemType: NODE
-  id: '1'
+  node_id: '1'
   name: node
-  baseType: SERVICE
-  nodeType: COMPUTER
+  node_class: SERVICE
+  node_type: COMPUTER
   priority: P1
-  hardwareState: 'ON'
-  ipAddress: 192.168.0.1
-  softwareState: GOOD
-  fileSystemState: GOOD
+  hardware_state: 'ON'
+  ip_address: 192.168.0.1
+  software_state: GOOD
+  file_system_state: GOOD
   services:
   - name: ftp
     port: '21'

tests/config/one_node_states_on_off_main_config.yaml

@@ -26,7 +26,7 @@ observationSpaceHighValue: 1000000000
 # Reward values
 # Generic
 allOk: 0
-# Node Operating State
+# Node Hardware State
 offShouldBeOn: -10
 offShouldBeResetting: -5
 onShouldBeOff: -2
@@ -34,7 +34,7 @@ onShouldBeResetting: -5
 resettingShouldBeOn: -5
 resettingShouldBeOff: -2
 resetting: -3
-# Node O/S or Service State
+# Node Software or Service State
 goodShouldBePatching: 2
 goodShouldBeCompromised: 5
 goodShouldBeOverwhelmed: 5