oxbrbtx/PrimAITE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

901 - Added another test and tidied up comments in test_observation_space.py and tidied up comments in observations.py

Browse Source
This commit is contained in:
SunilSamra
2023-07-14 14:51:26 +01:00
parent e5debcfc6c
commit 6b8cf73207
2 changed files with 83 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/primaite/environment/observations.py
View File

@@ -428,15 +428,15 @@ class AccessControlList(AbstractObservationComponent):
acl_rule2 position,
...
]
"""
# Terms (for ACL observation space):
# [0, 1, 2] - Permission (0 = NA, 1 = DENY, 2 = ALLOW)
# [0, num nodes] - Source IP (0 = NA, 1 = any, then 2 -> x resolving to IP addresses)
# [0, num nodes] - Dest IP (0 = NA, 1 = any, then 2 -> x resolving to IP addresses)
# [0, num services] - Protocol (0 = NA, 1 = any, then 2 -> x resolving to protocol)
# [0, num ports] - Port (0 = NA, 1 = any, then 2 -> x resolving to port)
# [0, max acl rules - 1] - Position (0 = NA, 1 = first index, then 2 -> x index resolving to acl rule in acl list)
Terms (for ACL Observation Space):
[0, 1, 2] - Permission (0 = NA, 1 = DENY, 2 = ALLOW)
[0, num nodes] - Source IP (0 = NA, 1 = any, then 2 -> x resolving to IP addresses)
[0, num nodes] - Dest IP (0 = NA, 1 = any, then 2 -> x resolving to IP addresses)
[0, num services] - Protocol (0 = NA, 1 = any, then 2 -> x resolving to protocol)
[0, num ports] - Port (0 = NA, 1 = any, then 2 -> x resolving to port)
[0, max acl rules - 1] - Position (0 = NA, 1 = first index, then 2 -> x index resolving to acl rule in acl list)
"""
_DATA_TYPE: type = np.int64
@@ -521,9 +521,6 @@ class AccessControlList(AbstractObservationComponent):
_LOGGER.info(f"Port {port} could not be found.")
port_int = None
# Either do the multiply on the obs space
# Change the obs to
print("current obs", port_int)
obs.extend(
[
permission_int,