oxbrbtx/PrimAITE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged PR 230: #2084: add coverage fail condition

Browse Source 
## Summary
Added a fail condition for coverage

## Test process
n/a

## Checklist
- [X] PR is linked to a **work item**
- [X] **acceptance criteria** of linked ticket are met
- [X] performed **self-review** of the code
- [X] written **tests** for any new functionality added with this PR
- [ ] updated the **documentation** if this PR changes or adds functionality
- [ ] written/updated **design docs** if this PR implements new functionality
- [ ] updated the **change log**
- [X] ran **pre-commit** checks for code style
- [ ] attended to any **TO-DOs** left in the code

#2084: add coverage fail condition

Related work items: #2084
This commit is contained in:
Czar Echavez
2023-12-04 10:02:24 +00:00
parent f55e18c4c8 8f063aa339
commit 6ca28f5d17
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.azure/azure-ci-build-pipeline.yaml
View File

@@ -95,7 +95,7 @@ stages:
version: '2.1.x' version: '2.1.x'
- script: | - script: |
coverage run -m --source=primaite pytest -v -o junit_family=xunit2 --junitxml=junit/test-results.xml coverage run -m --source=primaite pytest -v -o junit_family=xunit2 --junitxml=junit/test-results.xml --cov-fail-under=80
coverage xml -o coverage.xml -i coverage xml -o coverage.xml -i
coverage html -d htmlcov -i coverage html -d htmlcov -i
displayName: 'Run tests and code coverage' displayName: 'Run tests and code coverage'

6
tests/unit_tests/_primaite/_simulator/_network/test_container.py
View File

@@ -53,7 +53,7 @@ def test_reset_network(network):
server_1.power_off() server_1.power_off()
assert server_1.operating_state is NodeOperatingState.SHUTTING_DOWN assert server_1.operating_state is NodeOperatingState.SHUTTING_DOWN
assert network.describe_state() is not state_before assert network.describe_state() != state_before
network.reset_component_for_episode(episode=1) network.reset_component_for_episode(episode=1)
@@ -79,12 +79,16 @@ def test_apply_timestep_to_nodes(network):
assert client_1.operating_state is NodeOperatingState.ON assert client_1.operating_state is NodeOperatingState.ON
client_1.power_off() client_1.power_off()
assert client_1.operating_state is NodeOperatingState.SHUTTING_DOWN
for i in range(client_1.shut_down_duration + 1): for i in range(client_1.shut_down_duration + 1):
network.apply_timestep(timestep=i) network.apply_timestep(timestep=i)
assert client_1.operating_state is NodeOperatingState.OFF assert client_1.operating_state is NodeOperatingState.OFF
network.apply_timestep(client_1.shut_down_duration + 2)
assert client_1.operating_state is NodeOperatingState.OFF
def test_removing_node_that_does_not_exist(network): def test_removing_node_that_does_not_exist(network):
"""Node that does not exist on network should not affect existing nodes.""" """Node that does not exist on network should not affect existing nodes."""