From 7375bb383ab1e03fad55dba2b8426778edc1746c Mon Sep 17 00:00:00 2001 From: Marek Wolan Date: Tue, 18 Jun 2024 10:09:06 +0100 Subject: [PATCH] #2661 Improve style on ARP check code to be more concise --- src/primaite/simulator/system/services/arp/arp.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/primaite/simulator/system/services/arp/arp.py b/src/primaite/simulator/system/services/arp/arp.py index d7ab99a3..efadf189 100644 --- a/src/primaite/simulator/system/services/arp/arp.py +++ b/src/primaite/simulator/system/services/arp/arp.py @@ -139,13 +139,11 @@ class ARP(Service): ) if outbound_network_interface: # ensure we are not attempting to find the network address or broadcast address (not useable IPs) - intf_network_address = outbound_network_interface.ip_network.network_address - intf_broadcast_address = outbound_network_interface.ip_network.broadcast_address - if target_ip_address == intf_network_address: + if target_ip_address == outbound_network_interface.ip_network.network_address: self.sys_log.info(f"Cannot send ARP request to a network address {str(target_ip_address)}") return - if target_ip_address == intf_broadcast_address: - self.sys_log.info(f"Cannot send ARP request to a broadcast addresss {str(target_ip_address)}") + if target_ip_address == outbound_network_interface.ip_network.broadcast_address: + self.sys_log.info(f"Cannot send ARP request to a broadcast address {str(target_ip_address)}") return self.sys_log.info(f"Sending ARP request from NIC {outbound_network_interface} for ip {target_ip_address}")