From d8c85058edc2b80e9f9afcede098c9d133804d2f Mon Sep 17 00:00:00 2001 From: Charlie Crane Date: Fri, 13 Sep 2024 10:32:09 +0100 Subject: [PATCH 1/3] #2456 - Minor change to arp.show() to include port number --- src/primaite/simulator/system/services/arp/arp.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/primaite/simulator/system/services/arp/arp.py b/src/primaite/simulator/system/services/arp/arp.py index efadf189..9314bea7 100644 --- a/src/primaite/simulator/system/services/arp/arp.py +++ b/src/primaite/simulator/system/services/arp/arp.py @@ -47,7 +47,7 @@ class ARP(Service): :param markdown: If True, format the output as Markdown. Otherwise, use plain text. """ - table = PrettyTable(["IP Address", "MAC Address", "Via"]) + table = PrettyTable(["IP Address", "MAC Address", "Via", "Port"]) if markdown: table.set_style(MARKDOWN) table.align = "l" @@ -58,6 +58,7 @@ class ARP(Service): str(ip), arp.mac_address, self.software_manager.node.network_interfaces[arp.network_interface_uuid].mac_address, + self.software_manager.node.network_interfaces[arp.network_interface_uuid].port_num, ] ) print(table) From 94b30909ee62624181bbaa7187948f41f17b8164 Mon Sep 17 00:00:00 2001 From: Charlie Crane Date: Fri, 13 Sep 2024 10:56:12 +0100 Subject: [PATCH 2/3] #2456 - Updated Changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 77b7bb7d..71341a17 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ### Added - Log observation space data by episode and step. + +### Changed - ACL's are no longer applied to layer-2 traffic. +- ARP .show() method will no include the port number associated with each entry. + ## [3.3.0] - 2024-09-04 ### Added From 17035be0284f1789e026d4cf8328cc97b2035c8b Mon Sep 17 00:00:00 2001 From: Charlie Crane Date: Fri, 13 Sep 2024 11:13:55 +0100 Subject: [PATCH 3/3] #2456 - Actioning review comment --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 71341a17..53b29e85 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - ACL's are no longer applied to layer-2 traffic. -- ARP .show() method will no include the port number associated with each entry. +- ARP .show() method will now include the port number associated with each entry. ## [3.3.0] - 2024-09-04