From 7fe46ef99c78d675efd863d034976c8e733ccaf0 Mon Sep 17 00:00:00 2001 From: Christopher McCarthy Date: Mon, 3 Jul 2023 10:47:26 +0000 Subject: [PATCH] Apply suggestions from code review --- src/primaite/agents/agent.py | 2 +- src/primaite/agents/rllib.py | 2 +- src/primaite/environment/observations.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/primaite/agents/agent.py b/src/primaite/agents/agent.py index 50939210..685fe776 100644 --- a/src/primaite/agents/agent.py +++ b/src/primaite/agents/agent.py @@ -50,7 +50,7 @@ class AgentSessionABC(ABC): def __init__(self, training_config_path, lay_down_config_path): if not isinstance(training_config_path, Path): training_config_path = Path(training_config_path) - self._training_config_path: Final[Union[Path]] = training_config_path + self._training_config_path: Final[Union[Path, str]] = training_config_path self._training_config: Final[TrainingConfig] = training_config.load(self._training_config_path) if not isinstance(lay_down_config_path, Path): diff --git a/src/primaite/agents/rllib.py b/src/primaite/agents/rllib.py index 2b6a5a83..d851ba9c 100644 --- a/src/primaite/agents/rllib.py +++ b/src/primaite/agents/rllib.py @@ -55,7 +55,7 @@ class RLlibAgent(AgentSessionABC): msg = "Expected PPO or A2C agent_identifier, " f"got {self._training_config.agent_identifier.value}" _LOGGER.error(msg) raise ValueError(msg) - self._agent_config: PPOConfig + self._agent_config: Union[PPOConfig, A2CConfig] self._current_result: dict self._setup() diff --git a/src/primaite/environment/observations.py b/src/primaite/environment/observations.py index d0d5d46e..0470828e 100644 --- a/src/primaite/environment/observations.py +++ b/src/primaite/environment/observations.py @@ -57,7 +57,7 @@ class NodeLinkTable(AbstractObservationComponent): """ _FIXED_PARAMETERS: int = 4 - _MAX_VAL: int = 1_000_000 + _MAX_VAL: int = 1_000_000_000 _DATA_TYPE: type = np.int64 def __init__(self, env: "Primaite"):