#3075: Code review changes.

.azure/azure-ci-build-pipeline.yaml

@@ -113,8 +113,8 @@ stages:
           - script: |
               pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml
               notebooks_exit_code=$?
-              # Fail step if either of these do not have exit code 0
+              # Fail step if exit code not equal to 0
-              if [ $notebooks_exit_code -ne 0 ] || [ $package_notebooks_exit_code -ne 0 ]; then
+              if [ $notebooks_exit_code -ne 0 ]; then
                 exit 1
               fi
             displayName: 'Run notebooks on Linux and macOS'
@@ -124,9 +124,8 @@ stages:
           - script: |
               pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml
               set notebooks_exit_code=%ERRORLEVEL%
-              rem Fail step if either of these do not have exit code 0
+              rem Fail step if exit code not equal to 0
               if %notebooks_exit_code% NEQ 0 exit /b 1
-              if %package_notebooks_exit_code% NEQ 0 exit /b 1
             displayName: 'Run notebooks on Windows'
             condition: eq(variables['Agent.OS'], 'Windows_NT')
 

src/primaite/notebooks/Data-Manipulation-Customising-Red-Agent.ipynb

@@ -289,10 +289,10 @@
     "    action_space:\n",
     "      action_map:\n",
     "        0:\n",
-    "          action: do_nothing\n",
+    "          action: do-nothing\n",
     "          options: {}\n",
     "        1:\n",
-    "          action: node_application_execute\n",
+    "          action: node-application-execute\n",
     "          options:\n",
     "            node_name: client_1\n",
     "            application_name: DataManipulationBot\n",

tests/assets/configs/basic_switched_network.yaml

@@ -37,10 +37,10 @@ agents:
     action_space:
       action_map:
         0:
-          action: do_nothing
+          action: do-nothing
           options: {}
         1:
-          action: node_application_execute
+          action: node-application-execute
           options:
             node_name: client_2
             application_name: web-browser