From 8b91c280cbaa763f52b3ed270384d5ea71e13164 Mon Sep 17 00:00:00 2001 From: Marek Wolan Date: Wed, 12 Mar 2025 17:13:03 +0000 Subject: [PATCH] 3110 - remove outdated todos --- .../simulator/system/services/terminal/terminal.py | 2 -- .../_simulator/_network/_hardware/test_node_actions.py | 8 -------- 2 files changed, 10 deletions(-) diff --git a/src/primaite/simulator/system/services/terminal/terminal.py b/src/primaite/simulator/system/services/terminal/terminal.py index 112f6abc..08b22fe7 100644 --- a/src/primaite/simulator/system/services/terminal/terminal.py +++ b/src/primaite/simulator/system/services/terminal/terminal.py @@ -23,8 +23,6 @@ from primaite.utils.validation.ip_protocol import PROTOCOL_LOOKUP from primaite.utils.validation.port import PORT_LOOKUP -# TODO 2824: Since remote terminal connections and remote user sessions are the same thing, we could refactor -# the terminal to leverage the user session manager's list. This way we avoid potential bugs and code ducplication class TerminalClientConnection(BaseModel): """ TerminalClientConnection Class. diff --git a/tests/unit_tests/_primaite/_simulator/_network/_hardware/test_node_actions.py b/tests/unit_tests/_primaite/_simulator/_network/_hardware/test_node_actions.py index 425c0887..fa3d51b9 100644 --- a/tests/unit_tests/_primaite/_simulator/_network/_hardware/test_node_actions.py +++ b/tests/unit_tests/_primaite/_simulator/_network/_hardware/test_node_actions.py @@ -61,9 +61,6 @@ def test_node_os_scan(node): """Test OS Scanning.""" node.operating_state = NodeOperatingState.ON - # add process to node - # TODO implement processes - # add services to node node.software_manager.install(DummyService) service = node.software_manager.software.get("dummy-service") @@ -95,7 +92,6 @@ def test_node_os_scan(node): node.apply_timestep(timestep=i) # should update the state of all items - # TODO assert process.health_state_visible == SoftwareHealthState.COMPROMISED assert service.health_state_visible == SoftwareHealthState.COMPROMISED assert application.health_state_visible == SoftwareHealthState.COMPROMISED assert folder.visible_health_status == FileSystemItemHealthStatus.CORRUPT @@ -107,9 +103,6 @@ def test_node_red_scan(node): """Test revealing to red""" node.operating_state = NodeOperatingState.ON - # add process to node - # TODO implement processes - # add services to node node.software_manager.install(DummyService) service = node.software_manager.software.get("dummy-service") @@ -138,7 +131,6 @@ def test_node_red_scan(node): node.apply_timestep(timestep=i) # should update the state of all items - # TODO assert process.revealed_to_red is True assert service.revealed_to_red is True assert application.revealed_to_red is True assert folder.revealed_to_red is True