From 8f610a3dd9b9d6497d0216e1201b8ee8bceaa92b Mon Sep 17 00:00:00 2001
From: Charlie Crane <Charlie.Crane@t-s.qinetiq.com>
Date: Tue, 19 Nov 2024 19:39:23 +0000
Subject: [PATCH] #2912 - Minor changes to documentation page for extensible
 actions

---
 .../how_to_guides/extensible_actions.rst      |  4 +++-
 src/primaite/game/agent/actions/acl.py        | 19 -------------------
 2 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/docs/source/how_to_guides/extensible_actions.rst b/docs/source/how_to_guides/extensible_actions.rst
index 576aa75f..6e44a905 100644
--- a/docs/source/how_to_guides/extensible_actions.rst
+++ b/docs/source/how_to_guides/extensible_actions.rst
@@ -27,6 +27,8 @@ New actions to be used within PrimAITE require:
     class ExampleAction(AbstractAction, identifier="Example_action"):
         """An example action for demonstration purposes."""
 
+        config: "ExampleAction.ConfigSchema"
+
         class ConfigSchema(AbstractAction.ConfigSchema):
             """The configuration schema with all attributes expected goes here."""
             target_application: str
@@ -55,7 +57,7 @@ New actions to be used within PrimAITE require:
             "node",
             config.node_name,
             "file_system",
-            cls.model_fields["verb"].default,
+            config.verb,
             "folder",
             config.folder_name,
         ]
diff --git a/src/primaite/game/agent/actions/acl.py b/src/primaite/game/agent/actions/acl.py
index 7ab49732..e8ad59f5 100644
--- a/src/primaite/game/agent/actions/acl.py
+++ b/src/primaite/game/agent/actions/acl.py
@@ -84,19 +84,6 @@ class FirewallACLAddRuleAction(ACLAbstractAction, identifier="firewall_acl_add_r
 
     config: "FirewallACLAddRuleAction.ConfigSchema"
 
-    # max_acl_rules: int
-    # num_ips: int
-    # num_ports: int
-    # num_protocols: int
-    # num_permissions: int = 3
-    # permission: str
-    # target_firewall_nodename: str
-    # src_ip: str
-    # dst_ip: str
-    # dst_wildcard: str
-    # src_port: Union[int| None]
-    # dst_port: Union[int | None]
-
     class ConfigSchema(ACLAbstractAction.ConfigSchema):
         """Configuration schema for FirewallACLAddRuleAction."""
 
@@ -113,12 +100,6 @@ class FirewallACLAddRuleAction(ACLAbstractAction, identifier="firewall_acl_add_r
         source_wildcard_id: int
         dest_wildcard_id: int
 
-        # max_acl_rules: int
-        # num_ips: int
-        # num_ports: int
-        # num_protocols: int
-        # num_permissions: int = 3
-
     @classmethod
     def form_request(cls, config: ConfigSchema) -> List[str]:
         """Return the action formatted as a request which can be ingested by the PrimAITE simulation."""