From 94ee16afa6252422df6af438f3f473ca0112cb11 Mon Sep 17 00:00:00 2001 From: Marek Wolan Date: Tue, 21 Jan 2025 13:39:06 +0000 Subject: [PATCH] Remove todo comments that have been completed --- src/primaite/game/agent/observations/firewall_observation.py | 1 - src/primaite/simulator/system/services/terminal/terminal.py | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/primaite/game/agent/observations/firewall_observation.py b/src/primaite/game/agent/observations/firewall_observation.py index a89ddfc5..a194bb53 100644 --- a/src/primaite/game/agent/observations/firewall_observation.py +++ b/src/primaite/game/agent/observations/firewall_observation.py @@ -72,7 +72,6 @@ class FirewallObservation(AbstractObservation, identifier="FIREWALL"): self.ports: List[PortObservation] = [ PortObservation(where=self.where + ["NICs", port_num]) for port_num in (1, 2, 3) ] - # TODO: check what the port nums are for firewall. self.internal_inbound_acl = ACLObservation( where=self.where + ["internal_inbound_acl", "acl"], diff --git a/src/primaite/simulator/system/services/terminal/terminal.py b/src/primaite/simulator/system/services/terminal/terminal.py index 0d93248e..bda8bad3 100644 --- a/src/primaite/simulator/system/services/terminal/terminal.py +++ b/src/primaite/simulator/system/services/terminal/terminal.py @@ -286,7 +286,6 @@ class Terminal(Service, identifier="Terminal"): :param password: Password for login. :return: boolean, True if successful, else False """ - # TODO: Un-comment this when UserSessionManager is merged. connection_uuid = self.parent.user_session_manager.local_login(username=username, password=password) if connection_uuid: self.sys_log.info(f"{self.name}: Login request authorised, connection uuid: {connection_uuid}") @@ -413,7 +412,6 @@ class Terminal(Service, identifier="Terminal"): if isinstance(payload, SSHPacket): if payload.transport_message == SSHTransportMessage.SSH_MSG_USERAUTH_REQUEST: # validate & add connection - # TODO: uncomment this as part of 2781 username = payload.user_account.username password = payload.user_account.password connection_id = self.parent.user_session_manager.remote_login(