oxbrbtx/PrimAITE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source
This commit is contained in:
Marek Wolan
2023-11-17 20:30:07 +00:00
parent c5b4ae45be
commit 9d0a98b221
3 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/primaite/game/policy/sb3.py
View File

@@ -74,10 +74,6 @@ class SB3Policy(PolicyABC, identifier="SB3"):
"""Load agent from a checkpoint.""" """Load agent from a checkpoint."""
self._agent = self._agent_class.load(model_path, env=self.session.env) self._agent = self._agent_class.load(model_path, env=self.session.env)
def close(self) -> None:
"""Close the agent."""
pass
@classmethod @classmethod
def from_config(cls, config: "TrainingOptions", session: "PrimaiteSession") -> "SB3Policy": def from_config(cls, config: "TrainingOptions", session: "PrimaiteSession") -> "SB3Policy":
"""Create an agent from config file.""" """Create an agent from config file."""

2
tests/assets/configs/bad_primaite_session.yaml
View File

@@ -1,7 +1,7 @@
training_config: training_config:
rl_framework: SB3 rl_framework: SB3
rl_algorithm: PPO rl_algorithm: PPO
se3ed: 333 se3ed: 333 # Purposeful typo to check that error is raised with bad configuration.
n_learn_steps: 2560 n_learn_steps: 2560
n_eval_episodes: 5 n_eval_episodes: 5

6
tests/e2e_integration_tests/test_primaite_session.py
View File

@@ -1,3 +1,4 @@
import pydantic
import pytest import pytest
from tests.conftest import TempPrimaiteSession from tests.conftest import TempPrimaiteSession
@@ -5,6 +6,7 @@ from tests.conftest import TempPrimaiteSession
CFG_PATH = "tests/assets/configs/test_primaite_session.yaml" CFG_PATH = "tests/assets/configs/test_primaite_session.yaml"
TRAINING_ONLY_PATH = "tests/assets/configs/train_only_primaite_session.yaml" TRAINING_ONLY_PATH = "tests/assets/configs/train_only_primaite_session.yaml"
EVAL_ONLY_PATH = "tests/assets/configs/eval_only_primaite_session.yaml" EVAL_ONLY_PATH = "tests/assets/configs/eval_only_primaite_session.yaml"
MISCONFIGURED_PATH = "tests/assets/configs/bad_primaite_session.yaml"
class TestPrimaiteSession: class TestPrimaiteSession:
@@ -60,3 +62,7 @@ class TestPrimaiteSession:
session: TempPrimaiteSession session: TempPrimaiteSession
session.start_session() session.start_session()
# TODO: include checks that the model was loaded and that the eval-only session ran # TODO: include checks that the model was loaded and that the eval-only session ran
def test_error_thrown_on_bad_configuration(self):
with pytest.raises(pydantic.ValidationError):
session = TempPrimaiteSession.from_config(MISCONFIGURED_PATH)