Change typehints after mypy analysis

src/primaite/agents/hardcoded_acl.py

@@ -175,6 +175,7 @@ class HardCodedACLAgent(HardCodedAgentSessionABC):
 
         if protocol != "ANY":
             protocol = services_list[protocol - 1]  # -1 as dont have to account for ANY in list of services
+            # TODO: This should throw an error because protocol is a string
 
         matching_rules = acl.get_relevant_rules(source_node_address, dest_node_address, protocol, port)
         return matching_rules

src/primaite/agents/hardcoded_node.py

@@ -101,6 +101,7 @@ class HardCodedNodeAgent(HardCodedAgentSessionABC):
                     property_action,
                     action_service_index,
                 ]
+                # TODO: transform_action_node_enum takes only one argument, not sure why two are given here.
                 action = transform_action_node_enum(action, action_dict)
                 action = get_new_action(action, action_dict)
                 # We can only perform 1 action on each step

src/primaite/agents/sb3.py

@@ -39,6 +39,7 @@ class SB3Agent(AgentSessionABC):
             msg = f"Expected SB3 agent_framework, " f"got {self._training_config.agent_framework}"
             _LOGGER.error(msg)
             raise ValueError(msg)
+        self._agent_class: Union[PPO, A2C]
         if self._training_config.agent_identifier == AgentIdentifier.PPO:
             self._agent_class = PPO
         elif self._training_config.agent_identifier == AgentIdentifier.A2C: