From c1ba3b0850e35306b80ee48de430ff472a316caa Mon Sep 17 00:00:00 2001 From: SunilSamra Date: Tue, 22 Aug 2023 21:43:57 +0100 Subject: [PATCH] #1752 - Added comments to ticket --- src/primaite/simulator/system/services/dns_client.py | 3 +-- src/primaite/simulator/system/services/dns_server.py | 8 +++----- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/primaite/simulator/system/services/dns_client.py b/src/primaite/simulator/system/services/dns_client.py index f99411d2..97968407 100644 --- a/src/primaite/simulator/system/services/dns_client.py +++ b/src/primaite/simulator/system/services/dns_client.py @@ -78,6 +78,5 @@ class DNSClient(BaseModel): browser) :return: True if successful, False otherwise. """ - # check DNS packet (dns request, dns reply) here and see if it actually worked - + # check the DNS packet (dns request, dns reply) here and see if it actually worked pass diff --git a/src/primaite/simulator/system/services/dns_server.py b/src/primaite/simulator/system/services/dns_server.py index 7ad3bac1..a2eaf9d9 100644 --- a/src/primaite/simulator/system/services/dns_server.py +++ b/src/primaite/simulator/system/services/dns_server.py @@ -42,7 +42,7 @@ class DNSServer(BaseModel): :return ip_address: The IP address of that domain name or None. """ if target_domain in self.dns_table: - return self.dns_table[target_domain] + self.dns_table[target_domain] else: return None @@ -65,11 +65,9 @@ class DNSServer(BaseModel): :param payload: The payload to send. :return: True if successful, False otherwise. """ - ip_addresses = list(self.dns_table.values()) - domain_names = list(self.dns_table.keys()) - index_of_domain = ip_addresses.index(payload) + # DNS packet will be sent from DNS Server to the DNS client DNSPacket( - dns_request=DNSRequest(domain_name_request=domain_names[index_of_domain]), + dns_request=DNSRequest(domain_name_request=self.dns_table), dns_reply=DNSReply(domain_name_ip_address=payload), )