#2869 - Update type hints and ConfigSchema variables in some agent classes

src/primaite/game/agent/interface.py

@@ -6,7 +6,7 @@ from abc import abstractmethod
 from typing import Any, ClassVar, Dict, List, Optional, Tuple, Type, TYPE_CHECKING
 
 from gymnasium.core import ActType, ObsType
-from pydantic import BaseModel, ConfigDict, Field, model_validator
+from pydantic import BaseModel, ConfigDict, Field
 
 from primaite.game.agent.actions import ActionManager
 from primaite.game.agent.agent_log import AgentLog
@@ -72,32 +72,6 @@ class AbstractAgent(BaseModel):
 
         model_config = ConfigDict(extra="forbid", arbitrary_types_allowed=True)
         type: str = "AbstractAgent"
-        flatten_obs: bool = True
-        "Whether to flatten the observation space before passing it to the agent. True by default."
-        action_masking: bool = False
-        "Whether to return action masks at each step."
-        start_step: int = 5
-        "The timestep at which an agent begins performing it's actions"
-        frequency: int = 5
-        "The number of timesteps to wait between performing actions"
-        variance: int = 0
-        "The amount the frequency can randomly change to"
-
-        @model_validator(mode="after")
-        def check_variance_lt_frequency(self) -> "AbstractAgent.ConfigSchema":
-            """
-            Make sure variance is equal to or lower than frequency.
-
-            This is because the calculation for the next execution time is now + (frequency +- variance).
-            If variance were greater than frequency, sometimes the bracketed term would be negative
-            and the attack would never happen again.
-            """
-            if self.variance > self.frequency:
-                raise ValueError(
-                    f"Agent start settings error: variance must be lower than frequency "
-                    f"{self.variance=}, {self.frequency=}"
-                )
-            return self
 
     def __init_subclass__(cls, identifier: str, **kwargs: Any) -> None:
         if identifier in cls._registry: