From a4424608dd41f1b07e0778af858add47fc72b97a Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Fri, 28 Jun 2024 16:33:24 +0100 Subject: [PATCH 01/15] #2620: add nbmake and pytest xdist to run the notebooks as part of pieline --- .azure/azure-ci-build-pipeline.yaml | 5 +++++ pyproject.toml | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.azure/azure-ci-build-pipeline.yaml b/.azure/azure-ci-build-pipeline.yaml index aea94807..7ac50ea8 100644 --- a/.azure/azure-ci-build-pipeline.yaml +++ b/.azure/azure-ci-build-pipeline.yaml @@ -126,3 +126,8 @@ stages: inputs: codeCoverageTool: Cobertura summaryFileLocation: '$(System.DefaultWorkingDirectory)/**/coverage.xml' + # Run the notebooks to make sure that they work + - script: | + pytest --nbmake -n=auto src/primaite/notebooks + pytest --nbmake -n=auto src/primaite/simulator/_package_data + displayName: 'Run notebooks' diff --git a/pyproject.toml b/pyproject.toml index 9d53e961..badb1557 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -37,7 +37,9 @@ dependencies = [ "typer[all]==0.9.0", "pydantic==2.7.0", "ipywidgets", - "deepdiff" + "deepdiff", + "nbmake==1.5.4", + "pytest-xdist==3.6.1" ] [tool.setuptools.dynamic] From ce58f3960c7f3c1ab496df5e89369029997d972a Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Fri, 28 Jun 2024 16:43:10 +0100 Subject: [PATCH 02/15] #2620: downgrade pytest-xdist version --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index badb1557..cd4436bf 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -39,7 +39,7 @@ dependencies = [ "ipywidgets", "deepdiff", "nbmake==1.5.4", - "pytest-xdist==3.6.1" + "pytest-xdist==3.3.1" ] [tool.setuptools.dynamic] From ee4e152f13d920ed2d78eebc66f452d253b969aa Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Mon, 1 Jul 2024 12:00:17 +0100 Subject: [PATCH 03/15] #2620: publish result of test and checking if pipeline fails --- .azure/azure-ci-build-pipeline.yaml | 11 +++++++++-- .gitignore | 1 + src/primaite/notebooks/multi-processing.ipynb | 11 ++++++++++- 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/.azure/azure-ci-build-pipeline.yaml b/.azure/azure-ci-build-pipeline.yaml index 7ac50ea8..a45d26bc 100644 --- a/.azure/azure-ci-build-pipeline.yaml +++ b/.azure/azure-ci-build-pipeline.yaml @@ -128,6 +128,13 @@ stages: summaryFileLocation: '$(System.DefaultWorkingDirectory)/**/coverage.xml' # Run the notebooks to make sure that they work - script: | - pytest --nbmake -n=auto src/primaite/notebooks - pytest --nbmake -n=auto src/primaite/simulator/_package_data + pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml + pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml displayName: 'Run notebooks' + - task: PublishTestResults@2 + condition: succeededOrFailed() + inputs: + testRunner: JUnit + testResultsFiles: 'notebook-tests/**.xml' + testRunTitle: 'Publish Notebook run' + failTaskOnFailedTests: true diff --git a/.gitignore b/.gitignore index e48dc5dc..140a3d0b 100644 --- a/.gitignore +++ b/.gitignore @@ -54,6 +54,7 @@ cover/ tests/assets/**/*.png tests/assets/**/tensorboard_logs/ tests/assets/**/checkpoints/ +notebook-tests/*.xml # Translations *.mo diff --git a/src/primaite/notebooks/multi-processing.ipynb b/src/primaite/notebooks/multi-processing.ipynb index 86b549a7..6fc8b4c2 100644 --- a/src/primaite/notebooks/multi-processing.ipynb +++ b/src/primaite/notebooks/multi-processing.ipynb @@ -18,6 +18,15 @@ "Import packages and read config file." ] }, + { + "cell_type": "code", + "execution_count": null, + "metadata": {}, + "outputs": [], + "source": [ + "1/0" + ] + }, { "cell_type": "code", "execution_count": null, @@ -143,7 +152,7 @@ "name": "python", "nbconvert_exporter": "python", "pygments_lexer": "ipython3", - "version": "3.10.12" + "version": "3.10.11" } }, "nbformat": 4, From cb61756e43716ef3c82320cf4cce40b6bbec816c Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Mon, 1 Jul 2024 12:21:05 +0100 Subject: [PATCH 04/15] #2620: attempting to fail pipeline if notebook fails --- .azure/azure-ci-build-pipeline.yaml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.azure/azure-ci-build-pipeline.yaml b/.azure/azure-ci-build-pipeline.yaml index a45d26bc..a27fed25 100644 --- a/.azure/azure-ci-build-pipeline.yaml +++ b/.azure/azure-ci-build-pipeline.yaml @@ -109,6 +109,7 @@ stages: - task: PublishTestResults@2 condition: succeededOrFailed() + displayName: 'Publish Test Results' inputs: testRunner: JUnit testResultsFiles: 'junit/**.xml' @@ -131,10 +132,4 @@ stages: pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml displayName: 'Run notebooks' - - task: PublishTestResults@2 condition: succeededOrFailed() - inputs: - testRunner: JUnit - testResultsFiles: 'notebook-tests/**.xml' - testRunTitle: 'Publish Notebook run' - failTaskOnFailedTests: true From 4dd50be11ac9242084ec30030a7ff6e58f4d5df1 Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Mon, 1 Jul 2024 14:31:58 +0100 Subject: [PATCH 05/15] #2620: run notebooks after test so that the results can be published --- .azure/azure-ci-build-pipeline.yaml | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/.azure/azure-ci-build-pipeline.yaml b/.azure/azure-ci-build-pipeline.yaml index a27fed25..9217748b 100644 --- a/.azure/azure-ci-build-pipeline.yaml +++ b/.azure/azure-ci-build-pipeline.yaml @@ -107,12 +107,20 @@ stages: coverage html -d htmlcov -i displayName: 'Run tests and code coverage' + # Run the notebooks to make sure that they work + - script: | + pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml + pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml + displayName: 'Run notebooks' + - task: PublishTestResults@2 condition: succeededOrFailed() displayName: 'Publish Test Results' inputs: testRunner: JUnit - testResultsFiles: 'junit/**.xml' + testResultsFiles: | + 'junit/**.xml' + 'notebook-tests/**.xml' testRunTitle: 'Publish test results' failTaskOnFailedTests: true @@ -127,9 +135,3 @@ stages: inputs: codeCoverageTool: Cobertura summaryFileLocation: '$(System.DefaultWorkingDirectory)/**/coverage.xml' - # Run the notebooks to make sure that they work - - script: | - pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml - pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml - displayName: 'Run notebooks' - condition: succeededOrFailed() From a47a14b86e23d5533f5f88f84c49d1d64394a6af Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Mon, 1 Jul 2024 15:57:15 +0100 Subject: [PATCH 06/15] #2620: Going around azure dev ops to fail the script --- .azure/azure-ci-build-pipeline.yaml | 23 +++++++++++++++++++++-- pyproject.toml | 8 ++++---- 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/.azure/azure-ci-build-pipeline.yaml b/.azure/azure-ci-build-pipeline.yaml index 9217748b..47daa10f 100644 --- a/.azure/azure-ci-build-pipeline.yaml +++ b/.azure/azure-ci-build-pipeline.yaml @@ -109,8 +109,27 @@ stages: # Run the notebooks to make sure that they work - script: | - pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml - pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml + # Detect OS + if [ "$(uname)" = "Linux" ] || [ "$(uname)" = "Darwin" ]; then + # Commands for Linux and macOS + pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml + notebooks_exit_code=$? + pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml + package_notebooks_exit_code=$? + # Fail step if either of these do not have exit code 0 + if [ $notebooks_exit_code -ne 0 ] || [ $package_notebooks_exit_code -ne 0 ]; then + exit 1 + fi + else + # Commands for Windows + pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml + set notebooks_exit_code=%ERRORLEVEL% + pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml + set package_notebooks_exit_code=%ERRORLEVEL% + # Fail step if either of these do not have exit code 0 + if %notebooks_exit_code% NEQ 0 exit /b 1 + if %package_notebooks_exit_code% NEQ 0 exit /b 1 + fi displayName: 'Run notebooks' - task: PublishTestResults@2 diff --git a/pyproject.toml b/pyproject.toml index cd4436bf..a0c2e3eb 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -37,9 +37,7 @@ dependencies = [ "typer[all]==0.9.0", "pydantic==2.7.0", "ipywidgets", - "deepdiff", - "nbmake==1.5.4", - "pytest-xdist==3.3.1" + "deepdiff" ] [tool.setuptools.dynamic] @@ -74,7 +72,9 @@ dev = [ "Sphinx==7.1.2", "sphinx-copybutton==0.5.2", "wheel==0.38.4", - "nbsphinx==0.9.4" + "nbsphinx==0.9.4", + "nbmake==1.5.4", + "pytest-xdist==3.3.1" ] [project.scripts] From afcb844501a887e7d1c3e761cac9c3dd2f8d3749 Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Mon, 1 Jul 2024 16:45:28 +0100 Subject: [PATCH 07/15] #2620: remove cell that fails on purpose --- src/primaite/notebooks/multi-processing.ipynb | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/primaite/notebooks/multi-processing.ipynb b/src/primaite/notebooks/multi-processing.ipynb index 6fc8b4c2..305cfd70 100644 --- a/src/primaite/notebooks/multi-processing.ipynb +++ b/src/primaite/notebooks/multi-processing.ipynb @@ -18,15 +18,6 @@ "Import packages and read config file." ] }, - { - "cell_type": "code", - "execution_count": null, - "metadata": {}, - "outputs": [], - "source": [ - "1/0" - ] - }, { "cell_type": "code", "execution_count": null, From ab3e84b8b9ad78d947a6efa8b4a6e706bef94dc3 Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Mon, 1 Jul 2024 17:03:14 +0100 Subject: [PATCH 08/15] #2620: remove irrelevant change --- src/primaite/notebooks/multi-processing.ipynb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/primaite/notebooks/multi-processing.ipynb b/src/primaite/notebooks/multi-processing.ipynb index 305cfd70..86b549a7 100644 --- a/src/primaite/notebooks/multi-processing.ipynb +++ b/src/primaite/notebooks/multi-processing.ipynb @@ -143,7 +143,7 @@ "name": "python", "nbconvert_exporter": "python", "pygments_lexer": "ipython3", - "version": "3.10.11" + "version": "3.10.12" } }, "nbformat": 4, From 8097884ae2f3142fa75cd512a44d5d72895072cb Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Tue, 2 Jul 2024 00:00:20 +0100 Subject: [PATCH 09/15] #2620: modify script --- .azure/azure-ci-build-pipeline.yaml | 49 +++++++++++++++-------------- 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a/.azure/azure-ci-build-pipeline.yaml b/.azure/azure-ci-build-pipeline.yaml index 47daa10f..1176f52f 100644 --- a/.azure/azure-ci-build-pipeline.yaml +++ b/.azure/azure-ci-build-pipeline.yaml @@ -107,30 +107,33 @@ stages: coverage html -d htmlcov -i displayName: 'Run tests and code coverage' - # Run the notebooks to make sure that they work + # Run the notebooks - script: | - # Detect OS - if [ "$(uname)" = "Linux" ] || [ "$(uname)" = "Darwin" ]; then - # Commands for Linux and macOS - pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml - notebooks_exit_code=$? - pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml - package_notebooks_exit_code=$? - # Fail step if either of these do not have exit code 0 - if [ $notebooks_exit_code -ne 0 ] || [ $package_notebooks_exit_code -ne 0 ]; then - exit 1 - fi - else - # Commands for Windows - pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml - set notebooks_exit_code=%ERRORLEVEL% - pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml - set package_notebooks_exit_code=%ERRORLEVEL% - # Fail step if either of these do not have exit code 0 - if %notebooks_exit_code% NEQ 0 exit /b 1 - if %package_notebooks_exit_code% NEQ 0 exit /b 1 - fi - displayName: 'Run notebooks' + pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml + notebooks_exit_code=$? + pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml + package_notebooks_exit_code=$? + # Fail step if either of these do not have exit code 0 + if [ $notebooks_exit_code -ne 0 ] || [ $package_notebooks_exit_code -ne 0 ]; then + exit 1 + fi + displayName: 'Run notebooks on Linux and macOS' + condition: or(eq(variables['Agent.OS'], 'Linux'), eq(variables['Agent.OS'], 'Darwin')) + shell: bash + + # Run notebooks + - script: | + pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml + $notebooks_exit_code = $LASTEXITCODE + pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml + $package_notebooks_exit_code = $LASTEXITCODE + # Fail step if either of these do not have exit code 0 + if ($notebooks_exit_code -ne 0 -or $package_notebooks_exit_code -ne 0) { + exit 1 + } + displayName: 'Run notebooks on Windows' + condition: eq(variables['Agent.OS'], 'Windows_NT') + shell: pwsh - task: PublishTestResults@2 condition: succeededOrFailed() From 918eba2217b4bb2fbf97ef2092a25566302ca5ba Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Tue, 2 Jul 2024 00:25:30 +0100 Subject: [PATCH 10/15] #2620: fix indentation --- .azure/azure-ci-build-pipeline.yaml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.azure/azure-ci-build-pipeline.yaml b/.azure/azure-ci-build-pipeline.yaml index 1176f52f..24606c24 100644 --- a/.azure/azure-ci-build-pipeline.yaml +++ b/.azure/azure-ci-build-pipeline.yaml @@ -121,19 +121,19 @@ stages: condition: or(eq(variables['Agent.OS'], 'Linux'), eq(variables['Agent.OS'], 'Darwin')) shell: bash - # Run notebooks - - script: | - pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml - $notebooks_exit_code = $LASTEXITCODE - pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml - $package_notebooks_exit_code = $LASTEXITCODE - # Fail step if either of these do not have exit code 0 - if ($notebooks_exit_code -ne 0 -or $package_notebooks_exit_code -ne 0) { - exit 1 - } - displayName: 'Run notebooks on Windows' - condition: eq(variables['Agent.OS'], 'Windows_NT') - shell: pwsh + # Run notebooks + - script: | + pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml + $notebooks_exit_code = $LASTEXITCODE + pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml + $package_notebooks_exit_code = $LASTEXITCODE + # Fail step if either of these do not have exit code 0 + if ($notebooks_exit_code -ne 0 -or $package_notebooks_exit_code -ne 0) { + exit 1 + } + displayName: 'Run notebooks on Windows' + condition: eq(variables['Agent.OS'], 'Windows_NT') + shell: pwsh - task: PublishTestResults@2 condition: succeededOrFailed() From 1faacc8d7c3e7514356666b6d59b2143bb83b462 Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Tue, 2 Jul 2024 00:28:59 +0100 Subject: [PATCH 11/15] #2620: fix indentation --- .azure/azure-ci-build-pipeline.yaml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.azure/azure-ci-build-pipeline.yaml b/.azure/azure-ci-build-pipeline.yaml index 24606c24..afff0dbf 100644 --- a/.azure/azure-ci-build-pipeline.yaml +++ b/.azure/azure-ci-build-pipeline.yaml @@ -109,17 +109,17 @@ stages: # Run the notebooks - script: | - pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml - notebooks_exit_code=$? - pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml - package_notebooks_exit_code=$? - # Fail step if either of these do not have exit code 0 - if [ $notebooks_exit_code -ne 0 ] || [ $package_notebooks_exit_code -ne 0 ]; then - exit 1 - fi - displayName: 'Run notebooks on Linux and macOS' - condition: or(eq(variables['Agent.OS'], 'Linux'), eq(variables['Agent.OS'], 'Darwin')) - shell: bash + pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml + notebooks_exit_code=$? + pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml + package_notebooks_exit_code=$? + # Fail step if either of these do not have exit code 0 + if [ $notebooks_exit_code -ne 0 ] || [ $package_notebooks_exit_code -ne 0 ]; then + exit 1 + fi + displayName: 'Run notebooks on Linux and macOS' + condition: or(eq(variables['Agent.OS'], 'Linux'), eq(variables['Agent.OS'], 'Darwin')) + shell: bash # Run notebooks - script: | From 88ab3c3ca152512086e732194eb1a952ad3c3254 Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Tue, 2 Jul 2024 00:45:24 +0100 Subject: [PATCH 12/15] #2620: remove shell --- .azure/azure-ci-build-pipeline.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.azure/azure-ci-build-pipeline.yaml b/.azure/azure-ci-build-pipeline.yaml index afff0dbf..8d418ba5 100644 --- a/.azure/azure-ci-build-pipeline.yaml +++ b/.azure/azure-ci-build-pipeline.yaml @@ -119,7 +119,6 @@ stages: fi displayName: 'Run notebooks on Linux and macOS' condition: or(eq(variables['Agent.OS'], 'Linux'), eq(variables['Agent.OS'], 'Darwin')) - shell: bash # Run notebooks - script: | @@ -133,7 +132,6 @@ stages: } displayName: 'Run notebooks on Windows' condition: eq(variables['Agent.OS'], 'Windows_NT') - shell: pwsh - task: PublishTestResults@2 condition: succeededOrFailed() From 12a6aa5e7faa05aed0086e0f61433e33b3e4ce98 Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Tue, 2 Jul 2024 01:31:59 +0100 Subject: [PATCH 13/15] #2620: make the windows script work --- .azure/azure-ci-build-pipeline.yaml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.azure/azure-ci-build-pipeline.yaml b/.azure/azure-ci-build-pipeline.yaml index 8d418ba5..01111290 100644 --- a/.azure/azure-ci-build-pipeline.yaml +++ b/.azure/azure-ci-build-pipeline.yaml @@ -123,13 +123,12 @@ stages: # Run notebooks - script: | pytest --nbmake -n=auto src/primaite/notebooks --junit-xml=./notebook-tests/notebooks.xml - $notebooks_exit_code = $LASTEXITCODE + set notebooks_exit_code=%ERRORLEVEL% pytest --nbmake -n=auto src/primaite/simulator/_package_data --junit-xml=./notebook-tests/package-notebooks.xml - $package_notebooks_exit_code = $LASTEXITCODE - # Fail step if either of these do not have exit code 0 - if ($notebooks_exit_code -ne 0 -or $package_notebooks_exit_code -ne 0) { - exit 1 - } + set package_notebooks_exit_code=%ERRORLEVEL% + rem Fail step if either of these do not have exit code 0 + if %notebooks_exit_code% NEQ 0 exit /b 1 + if %package_notebooks_exit_code% NEQ 0 exit /b 1 displayName: 'Run notebooks on Windows' condition: eq(variables['Agent.OS'], 'Windows_NT') From a5a93fe8508dfd5e25898785aba244b216401ad7 Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Tue, 2 Jul 2024 02:10:40 +0100 Subject: [PATCH 14/15] #2620: commit a div zero to check that the pipeline fails --- src/primaite/notebooks/multi-processing.ipynb | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/primaite/notebooks/multi-processing.ipynb b/src/primaite/notebooks/multi-processing.ipynb index 86b549a7..bdf9a6b5 100644 --- a/src/primaite/notebooks/multi-processing.ipynb +++ b/src/primaite/notebooks/multi-processing.ipynb @@ -18,6 +18,15 @@ "Import packages and read config file." ] }, + { + "cell_type": "code", + "execution_count": null, + "metadata": {}, + "outputs": [], + "source": [ + "1/0" + ] + }, { "cell_type": "code", "execution_count": null, From e2429df2200f9941d67898bd7b3549182479831f Mon Sep 17 00:00:00 2001 From: Czar Echavez Date: Tue, 2 Jul 2024 02:52:08 +0100 Subject: [PATCH 15/15] #2620: remove div zero from notebook --- src/primaite/notebooks/multi-processing.ipynb | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/primaite/notebooks/multi-processing.ipynb b/src/primaite/notebooks/multi-processing.ipynb index bdf9a6b5..305cfd70 100644 --- a/src/primaite/notebooks/multi-processing.ipynb +++ b/src/primaite/notebooks/multi-processing.ipynb @@ -18,15 +18,6 @@ "Import packages and read config file." ] }, - { - "cell_type": "code", - "execution_count": null, - "metadata": {}, - "outputs": [], - "source": [ - "1/0" - ] - }, { "cell_type": "code", "execution_count": null, @@ -152,7 +143,7 @@ "name": "python", "nbconvert_exporter": "python", "pygments_lexer": "ipython3", - "version": "3.10.12" + "version": "3.10.11" } }, "nbformat": 4,