Merge agents and actions branches + fix import / subclass errors

src/primaite/simulator/system/applications/application.py

@@ -44,7 +44,7 @@ class Application(IOSoftware):
     _registry: ClassVar[Dict[str, Type["Application"]]] = {}
     """Registry of application types. Automatically populated when subclasses are defined."""
 
-    def __init_subclass__(cls, identifier: str = "default", **kwargs: Any) -> None:
+    def __init_subclass__(cls, identifier: Optional[str] = None, **kwargs: Any) -> None:
         """
         Register an application type.
 
@@ -52,9 +52,9 @@ class Application(IOSoftware):
         :type identifier: str
         :raises ValueError: When attempting to register an application with a name that is already allocated.
         """
-        if identifier == "default":
-            return
         super().__init_subclass__(**kwargs)
+        if identifier is None:
+            return
         if identifier in cls._registry:
             raise ValueError(f"Tried to define new application {identifier}, but this name is already reserved.")
         cls._registry[identifier] = cls

src/primaite/simulator/system/applications/database_client.py

@@ -308,6 +308,9 @@ class DatabaseClient(Application, identifier="DatabaseClient"):
         """
         if not self._can_perform_action():
             return None
+        if self.server_ip_address is None:
+            self.sys_log.warning(f"{self.name}: Database server IP address not provided.")
+            return None
 
         connection_request_id = str(uuid4())
         self._client_connection_requests[connection_request_id] = None

src/primaite/simulator/system/core/session_manager.py

@@ -16,7 +16,7 @@ from primaite.utils.validation.ip_protocol import IPProtocol, PROTOCOL_LOOKUP
 from primaite.utils.validation.port import Port, PORT_LOOKUP
 
 if TYPE_CHECKING:
-    from primaite.simulator.network.hardware.base import NetworkInterface
+    from primaite.simulator.network.hardware.base import NetworkInterface, Node
     from primaite.simulator.system.core.software_manager import SoftwareManager
     from primaite.simulator.system.core.sys_log import SysLog
 

src/primaite/simulator/system/services/service.py

@@ -52,7 +52,7 @@ class Service(IOSoftware):
     def __init__(self, **kwargs):
         super().__init__(**kwargs)
 
-    def __init_subclass__(cls, identifier: str = "default", **kwargs: Any) -> None:
+    def __init_subclass__(cls, identifier: Optional[str] = None, **kwargs: Any) -> None:
         """
         Register a hostnode type.
 
@@ -60,11 +60,11 @@ class Service(IOSoftware):
         :type identifier: str
         :raises ValueError: When attempting to register an hostnode with a name that is already allocated.
         """
-        if identifier == "default":
+        super().__init_subclass__(**kwargs)
+        if identifier is None:
             return
         # Enforce lowercase registry entries because it makes comparisons everywhere else much easier.
         identifier = identifier.lower()
-        super().__init_subclass__(**kwargs)
         if identifier in cls._registry:
             raise ValueError(f"Tried to define new hostnode {identifier}, but this name is already reserved.")
         cls._registry[identifier] = cls