Database Manipulation Bot bug fixes

src/primaite/config/_package_data/example_config.yaml

@@ -665,7 +665,7 @@ simulation:
         options:
           port_scan_p_of_success: 0.1
           data_manipulation_p_of_success: 0.1
-          payload: "DROP TABLE IF EXISTS user;"
+          payload: "DELETE"
           server_ip: 192.168.1.14
       services:
       - ref: client_1_dns_client

src/primaite/game/agent/interface.py

@@ -58,7 +58,7 @@ class AbstractAgent(ABC):
         action_space: Optional[ActionManager],
         observation_space: Optional[ObservationManager],
         reward_function: Optional[RewardFunction],
-        agent_settings: Optional[AgentSettings],
+        agent_settings: Optional[AgentSettings] = None,
     ) -> None:
         """
         Initialize an agent.
@@ -217,7 +217,7 @@ class DataManipulationAgent(AbstractScriptedAgent):
         :return: _description_
         :rtype: Tuple[str, Dict]
         """
-        current_timestep = self.action_space.session.step_counter
+        current_timestep = self.action_manager.session.step_counter
 
         if current_timestep < self.next_execution_timestep:
             return "DONOTHING", {"dummy": 0}

src/primaite/simulator/network/networks.py

@@ -140,7 +140,12 @@ def arcd_uc2_network() -> Network:
     network.connect(endpoint_b=client_1.ethernet_port[1], endpoint_a=switch_2.switch_ports[1])
     client_1.software_manager.install(DataManipulationBot)
     db_manipulation_bot: DataManipulationBot = client_1.software_manager.software["DataManipulationBot"]
-    db_manipulation_bot.configure(server_ip_address=IPv4Address("192.168.1.14"), payload="DELETE")
+    db_manipulation_bot.configure(
+        server_ip_address=IPv4Address("192.168.1.14"),
+        payload="DELETE",
+        port_scan_p_of_success=1.0,
+        data_manipulation_p_of_success=1.0,
+    )
 
     # Client 2
     client_2 = Computer(

src/primaite/simulator/system/applications/database_client.py

@@ -129,9 +129,9 @@ class DatabaseClient(Application):
             )
             return self._query(sql=sql, query_id=query_id, is_reattempt=True)
 
-    def execute(self) -> None:
+    def run(self) -> None:
         """Run the DatabaseClient."""
-        super().execute()
+        super().run()
         if self.operating_state == ApplicationOperatingState.RUNNING:
             self.connect()
 

src/primaite/simulator/system/services/red_services/data_manipulation_bot.py

@@ -50,7 +50,7 @@ class DataManipulationBot(DatabaseClient):
     def _init_request_manager(self) -> RequestManager:
         rm = super()._init_request_manager()
 
-        rm.add_request(name="execute", request_type=RequestType(func=lambda request, context: self.execute()))
+        rm.add_request(name="execute", request_type=RequestType(func=lambda request, context: self.run()))
 
         return rm
 
@@ -139,13 +139,13 @@ class DataManipulationBot(DatabaseClient):
                             self.sys_log.info(f"{self.name}: Data manipulation failed")
                             self.attack_stage = DataManipulationAttackStage.FAILED
 
-    def execute(self):
+    def run(self):
         """
-        Execute the Data Manipulation Bot.
+        Run the Data Manipulation Bot.
 
         Calls the parent classes execute method before starting the application loop.
         """
-        super().execute()
+        super().run()
         self._application_loop()
 
     def _application_loop(self):