Czar Echavez
6c4a538b41
#1522 : run pre-commit
2023-07-03 10:08:25 +01:00
Czar Echavez
4299170ce4
#1522 : added a check for existing links in laydown + test that checks if red agent instructions are random
2023-07-03 09:46:52 +01:00
Marek Wolan
ee94993344
Apply suggestions from code review
2023-07-03 08:00:51 +00:00
SunilSamra
41aed12f27
901 - merged with changes made to dev
2023-07-03 08:17:52 +01:00
Chris McCarthy
27ca53878a
#917 - Fixed the RLlib integration
...
- Dropped support for overriding the num_episodes and num_steps at the agent level. It's just not needed and will add complexity when overriding and writing output files.
2023-06-30 16:52:57 +01:00
Marek Wolan
605ff98a24
Fix flattening when there are no components.
2023-06-30 15:43:15 +01:00
Marek Wolan
2a8d28cba6
Remove redundant cols from transactions
2023-06-30 10:41:56 +01:00
Czar Echavez
3e691b4f46
#1522 : remove numpy randomisation + added random red agent config
2023-06-30 10:37:23 +01:00
Chris McCarthy
73015802ec
#917 - Integrated the PrimaiteSession into all tests.
...
- Ran a full pre-commit hook and thus encountered tons of fixes required
2023-06-30 09:08:13 +01:00
Marek Wolan
c77fde3dd3
Fix observation representation in transactions
2023-06-29 15:26:07 +01:00
Czar Echavez
f61d50a96f
#1522 : fixing create random red agent function
2023-06-29 15:03:11 +01:00
Czar Echavez
a2e02c3cfd
Merge branch 'dev' into feature/1522-Random-Red-Agent-Behaviour
2023-06-29 14:17:41 +01:00
Chris McCarthy
7f912df383
#917 - Began the process of reloading existing agents into the session
2023-06-28 19:54:00 +01:00
Chris McCarthy
1d3778f400
#917 - Overhauled transaction and mean reward writing.
...
- Separated out learning outputs from evaluation outputs
2023-06-28 16:34:00 +01:00
Chris McCarthy
7482192046
#917 - Synced with dev and added better logging
2023-06-28 12:01:01 +01:00
Marek Wolan
9666b92caa
Attempt to add flat spaces
2023-06-28 11:07:45 +01:00
Chris McCarthy
498e6a7ac1
Merge remote-tracking branch 'origin/dev' into feature/917_Integrate_with_RLLib
...
# Conflicts:
# src/primaite/config/training_config.py
# src/primaite/main.py
2023-06-28 10:11:03 +01:00
Marek Wolan
02f982afa8
Merged PR 95: Apply precommits and add precommit to build pipeline
...
## Summary
The code changes are purely cosmetic- the result of applying pre-commit to all our files. I also added a pre-commit step to the build pipeline to reject non-conforming PRs
## Test process
I saw that the build pipeline passes with this new step.
## Checklist
- [ ] This PR is linked to a **work item**
- [x] I have performed **self-review** of the code
- [ ] I have written **tests** for any new functionality added with this PR
- [ ] I have updated the **documentation** if this PR changes or adds functionality
- [x] I have run **pre-commit** checks for code style
Related work items: #1557
2023-06-28 08:14:49 +00:00
Chris McCarthy
746f878747
Merge remote-tracking branch 'origin/bugfix/1554-fix-not-learning-iers' into feature/917_Integrate_with_RLLib
2023-06-27 15:56:56 +01:00
Marek Wolan
a8c27ec975
Merge branch 'dev' into feature/build-pipeline-precommit
2023-06-27 15:49:49 +01:00
Marek Wolan
cffdcdc0d2
Fix ier reward calculation
2023-06-27 15:27:56 +01:00
Marek Wolan
be7d0e1745
Cosmetic changes to satisfy pre-commit
2023-06-27 13:06:10 +01:00
Marek Wolan
0bff2d2f36
Improve readability
2023-06-27 12:56:15 +01:00
Marek Wolan
79ecb8e0b9
More descriptive debug msg
2023-06-27 12:44:42 +01:00
Marek Wolan
ebc0a28460
rename to prevent confusion
2023-06-27 10:45:45 +00:00
SunilSamra
ef4d2c6cdd
901 - fixed test_single_action_space.py to reflect new acl structure and added new acl_implicit_rule class attribute
2023-06-27 11:43:33 +01:00
Marek Wolan
e2d6abf833
apply pre-commits
2023-06-27 11:20:18 +01:00
Marek Wolan
feead2cd44
Fix reference IERs
2023-06-27 11:10:21 +01:00
Brian Kanyora
e0f3d61f65
feature\1522:
...
Create random red agent behaviour.
2023-06-22 15:34:13 +01:00
Chris McCarthy
5a6fdf58d4
#917 - Got things working'ish
2023-06-20 22:29:46 +01:00
Chris McCarthy
a2cc4233b5
#917 -Finished integrating all agents to either train (policy agents) or evaluate (hard-coded agents). Still some fixing up to do, tidying up, loading etc. also docs. But this is all now working.
2023-06-20 16:06:55 +01:00
SunilSamra
df42a791c9
901 - changed ACL instantiation and changed acl t private _acl (list not dict) attribute, added laydown_ACL.yaml for testing, fixed encoding of acl rules to integers for obs space, added ACL position to node action space and added generic test where agents adds two ACL rules.
2023-06-20 11:47:20 +01:00
Chris McCarthy
03ae4884e0
#917 - Almost there. All output files being writen for SB3/RLLIB PPO & A2C. Just need to bring in the hardcoded agents then update the testa and docs.
2023-06-19 21:53:25 +01:00
Chris McCarthy
23bafde457
#917 - Integrated both SB3 and RLlib agents into PrimaiteSession
2023-06-19 20:27:08 +01:00
Chris McCarthy
c2c396052f
#917 - Got RLlib fully training in PrimAITE. Started integrating the the other agents into the Session class
2023-06-18 22:40:56 +01:00
SunilSamra
c6a947fbaf
901 - started testing for observation space
2023-06-13 16:23:32 +01:00
SunilSamra
5b59642695
901 - added max_acl_rules, implicit_acl_rule and apply_implicit rule to main_config, changed observations.py for ACLs to match the action space for ACLs, added position of acl rule to ACL action type
2023-06-13 14:51:55 +01:00
SunilSamra
cf64990cff
901 - added changes back to ticket
2023-06-13 09:45:45 +01:00
SunilSamra
cdd7183d85
901 - merged dev into my branch
2023-06-13 08:54:33 +01:00
Chris McCarthy
785409e12a
Synced with dev
2023-06-12 16:59:31 +01:00
Chris McCarthy
a08ec8844a
Merge remote-tracking branch 'origin/dev' into feature/915_PRI-31_Packaging_Deployment
...
# Conflicts:
# docs/source/about.rst
# src/primaite/main.py
# src/primaite/nodes/node.py
2023-06-12 16:42:26 +01:00
Chris McCarthy
8f86bda4d2
Merge remote-tracking branch 'origin/dev' into feature/898-Fix-the-functionality-of-resetting-a-node
2023-06-12 14:20:16 +01:00
Chris McCarthy
605737cd5f
#915 - Annotated logs func in cli.py to take -n.
...
- Fixed entry point on main.py
- Commented out the print reward line in step func of primaite_env.py.
- Added jupyterlab==3.6.1 to pyproject.toml
2023-06-09 16:44:49 +01:00
Chris McCarthy
f5e195604f
#915 - Synced with dev
2023-06-09 15:49:48 +01:00
SunilSamra
29ba64462a
901 - changed name of enum in enums.py and added class attriubutes in access_control_list.py
2023-06-09 15:45:13 +01:00
SunilSamra
afc133cbc5
901 - added ACL list to observations.py as its own observation space with the ACL attributes and the position of the ACL rule in the ACL list, added ImplicitFirewallRule to enums.py and added acl_implicit_rule, max_acl_list to primaite_env.py
2023-06-09 15:17:20 +01:00
Chris McCarthy
0dbd89e5cb
Merge remote-tracking branch 'origin/dev' into feature/915_PRI-31_Packaging_Deployment
...
# Conflicts:
# docs/source/about.rst
# docs/source/config.rst
# src/primaite/common/config_values_main.py
# src/primaite/environment/primaite_env.py
# src/primaite/main.py
# tests/config/multidiscrete_obs_space_laydown_config.yaml
# tests/config/obs_tests/laydown.yaml
# tests/conftest.py
# tests/test_observation_space.py
2023-06-09 13:41:05 +01:00
Chris McCarthy
af4e71db9b
#915 - Synced with dev to bring in changes from #898
2023-06-09 13:11:14 +01:00
Chris McCarthy
9b4ed1199b
Merge remote-tracking branch 'origin/dev' into feature/915_PRI-31_Packaging_Deployment
...
# Conflicts:
# tests/conftest.py
# tests/test_observation_space.py
# tests/test_reward.py
2023-06-09 10:35:14 +01:00
Marek Wolan
b917b65d49
Merge remote-tracking branch 'origin/dev' into feature/1468-observations-class
2023-06-09 09:01:54 +01:00