Marek Wolan
9cf5bfa1b2
Fix typehint issues
2023-07-31 17:07:56 +01:00
Marek Wolan
954026d3e0
Comment out RLLib support
2023-07-31 12:13:52 +01:00
Chris McCarthy
0fb9268f44
#1711 - Fully Integrated the legacy training config and lay down config options into the CLI, run PrimaiteSession, and Agent classes. Made the ese test in test_full_legacy_config_session.py use this new integrated option to read the legacy file.
2023-07-28 13:49:26 +01:00
Chris McCarthy
7c843d3caa
#1711 - Added the ability to load legacy lay down config files. Added extensive unit testing and end-to-end testing. Also added the ability to set exactly how many num_train_steps, num_eval_steps, num_train_episodes, and num_eval_episode and used when converting a legacy training config.
2023-07-28 12:53:49 +01:00
Chris McCarthy
1dc23e11f2
#1648 - Updated file header from 'Crown Owned Copyright (C) Dstl 2023. DEFCON 703. Shared in confidence.' to '© Crown-owned copyright 2023, Defence Science and Technology Laboratory UK'
2023-07-21 14:54:09 +01:00
Chris McCarthy
90d825736b
#1594 - Managed to get the evaluation of rllib agents working. A test has been added to test_primaite_session.py that now tests the full RLlib agent from end-to-end. I;ve also updated the tests in here to check that the mean reward per episode plot is created for both too. This will need a bit of a re-design further down the line, but for now, it works. Added a custom exception for RLlib eval only error.
2023-07-20 19:58:48 +01:00
Marek Wolan
652c9f1b90
Merge remote-tracking branch 'origin/dev' into feature/901-change-functionality-acl-rules
2023-07-18 10:55:31 +01:00
Marek Wolan
0d521bc96b
Remove redundant 'if TYPE_CHECKING' statements
2023-07-18 10:21:06 +01:00
Marek Wolan
471826e5ce
Merge branch 'dev' into feature/1623-typehints
2023-07-18 10:03:48 +01:00
SunilSamra
f5b18e882c
#901 - Replaced "ALLOW" with RulePermissionType.ALLOW
...
- Added Explicit ALLOW to test_configs in order for tests to work
- Added typing to access_control_list.py and acl_rule.py
2023-07-17 20:40:00 +01:00
Chris McCarthy
f4683f3b66
#1631 - Updated the copyright statement to comply with DEFCON 703 Edition 08/13
2023-07-17 19:57:34 +01:00
SunilSamra
bacb42833f
#901 - ran black pre-commit over observations.py to fix it
2023-07-17 19:42:05 +01:00
Chris McCarthy
678f953ced
#1631 - Added the DEFCON 703 header to all possible files
2023-07-17 19:28:43 +01:00
Marek Wolan
4032f3a2a8
Change typehints after mypy analysis
2023-07-17 16:22:07 +01:00
Sunil Samra
d67df9234d
Apply suggestions from code review
2023-07-17 14:21:37 +00:00
SunilSamra
8008fab523
#901 - Removed flatten from training configs
...
- Added flatten operation in observations.py when there are multiple obs components
- Updated config.rst docs
2023-07-17 13:44:16 +01:00
SunilSamra
cb4089a0ba
#901
...
- Removed bool apply_implicit_rule
- Set default implicit_rule to EXPLICIT DENY
- Added position to ACLs in laydown configs
- Removed apply_implicit_rule from training configs
2023-07-17 13:00:58 +01:00
Marek Wolan
98ac228f90
Fix types according to mypy
2023-07-14 16:38:55 +01:00
SunilSamra
a2461d29b4
#901 - amended comment in observations.py
2023-07-14 16:04:13 +01:00
SunilSamra
fc1a575fd0
#901 -
...
- Added comments in access_control_list.py
- Changed obs_shape to max_number_acl_rules from max_number_acl_rules + 1 as index starts from 1
- Commented episode and step print line from test_single_action_space.py
2023-07-14 15:27:37 +01:00
SunilSamra
6b8cf73207
901 - Added another test and tidied up comments in test_observation_space.py and tidied up comments in observations.py
2023-07-14 14:51:26 +01:00
SunilSamra
4a0d688ae6
901 - fixed test_observation_space.py, added test fixture for test_seeding_and_deterministic_session.py and increased default max number of acls
2023-07-14 12:29:50 +01:00
Marek Wolan
a923d818d3
Add More Typehint
2023-07-13 18:08:44 +01:00
SunilSamra
79d77c85c4
Merge remote-tracking branch 'origin/dev' into feature/901-change-functionality-acl-rules
2023-07-13 16:48:02 +01:00
Marek Wolan
4e4166d4d4
Continue Adding Typehints
2023-07-13 12:25:54 +01:00
SunilSamra
771061a218
901 - fixed test_single_action_space.py test
2023-07-13 11:45:23 +01:00
SunilSamra
ad4198da13
901 - changed acl current obs from list to numpy.array, changed default ACL list in training_config.py to FALSE, and tried to make test_seeding_and_deterministic_session.py test without fixed reward results
2023-07-13 11:04:11 +01:00
SunilSamra
e192d24800
Merge remote-tracking branch 'origin/dev' into feature/901-change-functionality-acl-rules
...
# Conflicts:
# src/primaite/acl/access_control_list.py
2023-07-12 10:45:03 +01:00
SunilSamra
f14963b6fb
Merge remote-tracking branch 'origin/dev' into feature/1566-configure_episode-steps-learn-eval
...
# Conflicts:
# src/primaite/config/training_config.py
2023-07-11 11:39:21 +01:00
Chris McCarthy
1ddfca6459
#1566 - Refactored the test_train_eval_episode_steps.py to sue TempPrimaiteSession.
...
- Fixed all errors that were caused b fixing the above.
- Some tests still fail, these are for SS to fix.
- Dropped the old run_generic stuff from conftest.py
2023-07-07 15:50:14 +01:00
SunilSamra
4902ccd2b4
Merge remote-tracking branch 'origin/dev' into feature/901-change-functionality-acl-rules
2023-07-07 15:14:05 +01:00
Chris McCarthy
8edb26a65c
Merge remote-tracking branch 'origin/dev' into 1566-configure-episode-steps-learn-eval
...
# Conflicts:
# src/primaite/agents/rllib.py
2023-07-07 14:34:20 +01:00
SunilSamra
79d98e977b
1566 - added test file and edited configs to include types of num steps and modifed agents to use correct step and episode counts
2023-07-07 14:13:47 +01:00
Marek Wolan
1d1f3f2403
Merge remote-tracking branch 'origin/dev' into feature/1572-fix-docs-formatting
2023-07-07 10:30:11 +01:00
Marek Wolan
5618283cc5
Standardise docstring summary line placement.
2023-07-07 10:28:00 +01:00
Marek Wolan
653d76ec62
Added docstrings to class intialisers
2023-07-06 16:08:51 +01:00
Marek Wolan
dd8593e489
Change reward to float and divide by 10000
2023-07-06 12:52:14 +01:00
SunilSamra
7a02661c66
901 - changed how acl rules are added to access control list and added structure to AccessControlList observation
2023-07-06 11:07:21 +01:00
SunilSamra
35045f4842
901 - merged with dev
2023-07-05 11:34:15 +01:00
Marek Wolan
24a4f96ed0
Add blank lines at the end of file.
2023-07-05 09:22:49 +01:00
SunilSamra
766ee9624a
901 - updated observations.py to change and add new mapping of ACL rules to represent no rule present in list
2023-07-05 09:08:03 +01:00
Marek Wolan
544d8777ea
add module level docstrings
2023-07-04 13:11:06 +01:00
Marek Wolan
5db8bd7c4c
Resolve remaining build warnings for docs
2023-07-04 11:34:36 +01:00
Marek Wolan
9244c160b1
Format docstrings
2023-07-04 11:11:52 +01:00
Marek Wolan
91273b2f99
fix formatting on Observation docs
2023-07-04 10:57:00 +01:00
Chris McCarthy
27e22edaf1
#917 - Reinstalled the pre-commit hook
2023-07-03 20:40:38 +01:00
Chris McCarthy
e271a28bf0
#917 - Synced with dev and integrated the new observation space
2023-07-03 20:36:21 +01:00
Chris McCarthy
1716786441
Merge remote-tracking branch 'origin/dev' into feature/917_Integrate_with_RLLib
...
# Conflicts:
# src/primaite/config/_package_data/training/training_config_main.yaml
# src/primaite/environment/primaite_env.py
# src/primaite/main.py
# src/primaite/transactions/transaction.py
# src/primaite/transactions/transactions_to_file.py
2023-07-03 19:51:52 +01:00
Chris McCarthy
c36ddfa03f
#917 - Synced with dev (at the point of random red agent)
2023-07-03 17:25:21 +01:00
Chris McCarthy
d55225dd41
Merge remote-tracking branch 'origin/dev' into feature/917_Integrate_with_RLLib
...
# Conflicts:
# src/primaite/config/_package_data/training/training_config_main.yaml
# src/primaite/environment/primaite_env.py
2023-07-03 15:07:09 +01:00