Charlie Crane
4bddf72cd3
#2706 - Initial refactor of Terminal Class following review discussion on Friday. Terminal will now return a TerminalConnection/RemoteTerminalConnection object on login.
...
The new connection object can then be used to pass commands to the target node, without needing to form a full payload item.
2024-08-05 09:29:17 +01:00
Charlie Crane
d9faa1a5da
Merge branch 'dev' into feature/2706-Terminal_Sim_Component
2024-08-02 13:34:00 +01:00
Charlie Crane
e132c52121
#2706 - Removed the LoginValidator. Will be handled by UserSessionManager. Updated some missing variables in method definitions/
2024-08-02 13:32:34 +01:00
Nick Todd
3ebad7d7e9
Merged PR 448: Global NMNE variables are incorrectly accessed
...
## Summary
*Replace this text with an explanation of what the changes are and how you implemented them. Can this impact any other parts of the codebase that we should keep in mind?*
## Test process
*How have you tested this (if applicable)?*
## Checklist
- [X] PR is linked to a **work item**
- [X] **acceptance criteria** of linked ticket are met
- [X] performed **self-review** of the code
- [X] written **tests** for any new functionality added with this PR
- [ ] updated the **documentation** if this PR changes or adds functionality
- [ ] written/updated **design docs** if this PR implements new functionality
- [ ] updated the **change log**
- [X] ran **pre-commit** checks for code style
- [X] attended to any **TO-DOs** left in the code
Related work items: #2676
2024-08-02 08:28:08 +00:00
Charlie Crane
ab4931463f
#2706 - Minor change following the session_id changes as local_login failed to pass a session_id when creating a new TerminalClientConnection object
2024-08-02 09:21:55 +01:00
Charlie Crane
0fe61576c7
#2706 - Removed source and target ip_address attributes from the SSHPacket Class. Terminal now uses session_id to send login outcome. No more network_interface[1].ip_address.
2024-08-02 09:13:31 +01:00
Charlie Crane
19d7774440
#2706 - Changed how Terminal Class handles its connections. Terminal now has a list of TerminalClientConnection objects that holds all active connections. Corrected a typo in ssh.py
2024-08-01 12:34:21 +01:00
Marek Wolan
b599257433
#2676 - update configs to use new nmne schema; fix test and warnings
2024-08-01 09:06:35 +01:00
Charlie Crane
5ef9e78a44
#2706 - Elaborated on terminal login within notebook
2024-08-01 08:37:51 +01:00
Charlie Crane
e4e3e17f51
#2706 - commit minor changes from review comments
2024-08-01 07:57:01 +01:00
Marek Wolan
2abd1969fe
#2800 - Consolidate software install and uninstall to a single method
2024-07-31 16:41:59 +01:00
Charlie Crane
0f3fa79ffe
#2706 - Actioning review comments on example notebook and terminal class
2024-07-31 15:47:18 +01:00
Marek Wolan
bd1e23db7d
2676 - make ntwk intf use default nmne config
2024-07-31 15:25:02 +01:00
Marek Wolan
9bf8d0f8cb
#2676 Put NMNE back into network module
2024-07-31 13:20:15 +01:00
Marek Wolan
5b976c7985
Merge remote-tracking branch 'origin/dev' into bugfix/2676_NMNE_var_access
2024-07-31 12:49:21 +01:00
Charlie Crane
06ac127f6b
#2706 - Updates to Terminal Processing notebook to highlight utility function and improve formatting
2024-07-30 16:58:40 +01:00
Charlie Crane
3698e6ff5f
#2706 - Commented out references to UserSessionManager to remove the dependency.
2024-07-30 15:24:37 +01:00
Charlie Crane
09084574a8
#2706 - Inclusion of health_state_actual attribute to the Terminal class. Started fleshing out a walkthrough notebook showing how to use the new component.
2024-07-30 12:15:37 +01:00
Charlie Crane
bb0ecb93a4
#2706 - Correcting whitespace change in database_service.py and actioning some review comments
2024-07-30 09:57:47 +01:00
Charlie Crane
e492f19a43
#2706 - Small change to execute method following feedback
2024-07-29 17:10:13 +01:00
Charlie Crane
f78cb24150
#2706 - Removed some un-necessary comments and changes to network used in terminal ACL unit test
2024-07-29 14:20:29 +01:00
Charlie Crane
cf7341a4fd
#2713 - Minor changes before merging into main Terminal branch
2024-07-29 10:50:32 +01:00
Charlie Crane
0ac1c6702c
#2713 - eod commit. Initial RequestManager Test implemented, along with an initial setup of the additional Request Manager methods.
2024-07-26 16:56:03 +01:00
Charlie Crane
a0e675a09a
#2712 - Minor changes to login Validator
2024-07-24 11:20:01 +01:00
Charlie Crane
1cb6ce02e0
#2712 - Correcting the use of TerminalClientConnection for remote connections. Terminal should hold a list of active remote connections to itself with connection uuid for validation
2024-07-24 10:38:12 +01:00
Charlie Crane
a36e34ee1d
#2712 - Prepping ahead of raising PR.
2024-07-24 08:31:24 +01:00
Charlie Crane
9d5b58ce44
Merge branch 'dev' into feature/2712-Terminal_Login_Handling
2024-07-23 15:52:42 +01:00
Charlie Crane
a7f9e4502e
#2712 - Updates to the login logic and fixing resultant test failures. Updates to terminal.rst and ssh.py
2024-07-23 15:18:20 +01:00
Chris McCarthy
e67b4b54ce
bumped version number and ran pre-commit
2024-07-22 14:46:58 +01:00
Charlie Crane
3c590a8733
#2712 - Commit before changing branches
2024-07-22 09:58:09 +01:00
Nick Todd
82a11b8b85
#2676 : Updated doc strings
2024-07-19 12:54:01 +01:00
Nick Todd
e4ade6ba54
#2676 : Merge nmne.py with io.py
2024-07-19 12:02:43 +01:00
Charlie Crane
5c04f4fa4c
Merge branch 'dev' into feature/2712-Terminal_Login_Handling
2024-07-19 11:18:34 +01:00
Charlie Crane
155562cb68
#2712 - Commit before merging in changes on dev
2024-07-19 11:18:17 +01:00
Charlie Crane
2104a7ec7d
#2712 - Commit before merging in changes on dev
2024-07-19 11:17:54 +01:00
Nick Todd
9fb3790c1a
#2726 : Resolve pydantic validators PR comment
2024-07-19 11:10:57 +01:00
Nick Todd
ec6d7b46d1
Merge branch 'dev' into bugfix/2676_NMNE_var_access
2024-07-19 08:57:12 +01:00
Nick Todd
4361734014
#2676 : Code review changes
2024-07-17 17:50:55 +01:00
Christopher McCarthy
b651ee3837
fixed line ending in VERSION
2024-07-17 16:08:30 +00:00
Christopher McCarthy
6b14d6de44
Bumped version number to 3.3.0-dev0
2024-07-17 15:45:25 +00:00
Archer Bowen
05c33b57e0
Merged PR 465: 2734 - Initial User Guide Updates
...
## Summary
3.2 User Guide Updates for 3.2 release.
Related work items: #2734
2024-07-17 15:18:17 +00:00
Archer.Bowen
e9d9cea739
Updated action masking to include copyright
2024-07-17 14:27:01 +01:00
Archer.Bowen
fd57986512
#2757 fixed dev mode cli double -level alternative issue
2024-07-17 11:48:29 +01:00
Nick Todd
061509dffd
#2676 : Further test fixes.
2024-07-17 10:43:04 +01:00
Archer.Bowen
bc660d651d
2734 - Initial User Guide Updates
2024-07-16 09:32:26 +01:00
Nick Todd
34969c588b
#2676 : Fix mismerge.
2024-07-16 08:59:36 +01:00
Marek Wolan
99af67023a
Updated VERSION
2024-07-15 13:41:01 +00:00
Charlie Crane
fee7f202a6
#2711 - Amending some minor changes spotted whilst raising PR
2024-07-15 10:06:28 +01:00
Nick Todd
0e3227c691
Merge branch 'dev' into bugfix/2676_NMNE_var_access
2024-07-15 09:27:11 +01:00
Charlie Crane
32c2ea0b10
#2710 - Pre-commit run ahead of raising PR
2024-07-15 08:22:18 +01:00