SunilSamra
c6a947fbaf
901 - started testing for observation space
2023-06-13 16:23:32 +01:00
SunilSamra
5b59642695
901 - added max_acl_rules, implicit_acl_rule and apply_implicit rule to main_config, changed observations.py for ACLs to match the action space for ACLs, added position of acl rule to ACL action type
2023-06-13 14:51:55 +01:00
SunilSamra
cf64990cff
901 - added changes back to ticket
2023-06-13 09:45:45 +01:00
SunilSamra
cdd7183d85
901 - merged dev into my branch
2023-06-13 08:54:33 +01:00
Chris McCarthy
785409e12a
Synced with dev
2023-06-12 16:59:31 +01:00
Chris McCarthy
a08ec8844a
Merge remote-tracking branch 'origin/dev' into feature/915_PRI-31_Packaging_Deployment
...
# Conflicts:
# docs/source/about.rst
# src/primaite/main.py
# src/primaite/nodes/node.py
2023-06-12 16:42:26 +01:00
Chris McCarthy
8f86bda4d2
Merge remote-tracking branch 'origin/dev' into feature/898-Fix-the-functionality-of-resetting-a-node
2023-06-12 14:20:16 +01:00
Chris McCarthy
605737cd5f
#915 - Annotated logs func in cli.py to take -n.
...
- Fixed entry point on main.py
- Commented out the print reward line in step func of primaite_env.py.
- Added jupyterlab==3.6.1 to pyproject.toml
2023-06-09 16:44:49 +01:00
Chris McCarthy
f5e195604f
#915 - Synced with dev
2023-06-09 15:49:48 +01:00
SunilSamra
29ba64462a
901 - changed name of enum in enums.py and added class attriubutes in access_control_list.py
2023-06-09 15:45:13 +01:00
SunilSamra
afc133cbc5
901 - added ACL list to observations.py as its own observation space with the ACL attributes and the position of the ACL rule in the ACL list, added ImplicitFirewallRule to enums.py and added acl_implicit_rule, max_acl_list to primaite_env.py
2023-06-09 15:17:20 +01:00
Chris McCarthy
0dbd89e5cb
Merge remote-tracking branch 'origin/dev' into feature/915_PRI-31_Packaging_Deployment
...
# Conflicts:
# docs/source/about.rst
# docs/source/config.rst
# src/primaite/common/config_values_main.py
# src/primaite/environment/primaite_env.py
# src/primaite/main.py
# tests/config/multidiscrete_obs_space_laydown_config.yaml
# tests/config/obs_tests/laydown.yaml
# tests/conftest.py
# tests/test_observation_space.py
2023-06-09 13:41:05 +01:00
Chris McCarthy
af4e71db9b
#915 - Synced with dev to bring in changes from #898
2023-06-09 13:11:14 +01:00
Chris McCarthy
9b4ed1199b
Merge remote-tracking branch 'origin/dev' into feature/915_PRI-31_Packaging_Deployment
...
# Conflicts:
# tests/conftest.py
# tests/test_observation_space.py
# tests/test_reward.py
2023-06-09 10:35:14 +01:00
Marek Wolan
b917b65d49
Merge remote-tracking branch 'origin/dev' into feature/1468-observations-class
2023-06-09 09:01:54 +01:00
Chris McCarthy
de86c85b23
#915 - Refactored documentation and included APi docs, dependencies.
...
- make files now re-build autosummary and deps file.
- Added typer and platformdirs to deps in pyproject.toml.
- Made root_is_pure = True in setup.py as platform/python specific wheels don't need to be built but the option is there should we need to.
-
Added an e2e test for primaite.main.run func.
2023-06-08 15:57:38 +01:00
Chris McCarthy
273876873e
#915 - Created app dirs and set as constants in the top-level init.
...
- renamed _config_values_main to training_config.py and renamed the ConfigValuesMain class to TrainingConfig.
Moved training_config.py to src/primaite/config/training_config.py
- Renamed all training config yaml file keys to make creating an instance of TrainingConfig easier.
Moved action_type and num_steps over to the training config.
- Decoupled the training config and lay down config.
- Refactored main.py so that it can be ran from CLI and can take a training config path and a lay down config path.
- refactored all outputs so that they save to the session dir.
- Added some necessary setup scripts that handle creating app dirs, fronting example config files to the user, fronting demo notebooks to the user, performing clean-up in between installations etc.
- Added functions that attempt to retrieve the file path of users example config files that have been fronted by the primaite setup.
- Added logging config and a getLogger function in the top-level init.
- Refactored all logs entries logged to use a logger using the primaite logging config.
- Added basic typer CLI for doing things like setup, viewing logs, viewing primaite version, running a basic session.
- Updated test to use new features and config structures.
- Began updating docs. More to do here.
2023-06-07 22:40:16 +01:00
Marek Wolan
9417cd85ab
Apply suggestions from code review.
2023-06-07 15:25:11 +01:00
SunilSamra
709fbc500e
893 - removed print statements for demonstration
2023-06-07 09:19:30 +01:00
SunilSamra
6cc9516744
893 - added new line for assert statements
2023-06-06 15:54:35 +01:00
SunilSamra
69c5c9458b
893 -
2023-06-06 13:47:07 +01:00
SunilSamra
af44b99b6f
Merge remote-tracking branch 'origin/dev' into feature/893-node-acl-into-one-action-space
2023-06-06 13:46:01 +01:00
Marek Wolan
c969bc32f5
Merge remote-tracking branch 'origin/dev' into feature/1468-observations-class
2023-06-06 13:40:17 +01:00
SunilSamra
d922d4d054
893 - returned config_values in conftest to move run_generic_set_actions into test_single_action_space.py
2023-06-06 13:21:04 +01:00
SunilSamra
e15c8c8c89
893 - applied changes raised during PR
2023-06-06 13:12:28 +01:00
SunilSamra
17d036302f
Merge remote-tracking branch 'origin/dev' into feature/893-node-acl-into-one-action-space
2023-06-06 11:56:52 +01:00
SunilSamra
49707b0a17
893 - set the action_space to NOTHING so test_reward.py passes and removed unnecessary test print statements
2023-06-06 11:10:38 +01:00
SunilSamra
55f13ae654
893 - added new tests to test action space size and node is completing both sets of actions in a single episode and created new main config
2023-06-06 11:00:41 +01:00
Brian Kanyora
051cd7da2b
Merge branch 'dev' into feature/898-Fix-the-functionality-of-resetting-a-node
2023-06-02 14:56:31 +01:00
Brian Kanyora
e5b60c2f95
feature\898:
2023-06-02 14:54:23 +01:00
Marek Wolan
cdd710d672
Merge remote-tracking branch 'origin/dev' into bugfix/1442-reward-ignores-red-pol
2023-06-02 14:22:45 +01:00
Marek Wolan
25ec0d93a9
Fix Link Traffic Levels observation encoding
2023-06-02 13:15:38 +01:00
Marek Wolan
f37b943f7e
Add tests for observations
2023-06-02 12:59:01 +01:00
SunilSamra
2c95087056
893 - added test which shows the new action space has been created when ANY is selected in single_action_space_lay_down_config.yaml
2023-06-02 11:55:31 +01:00
Marek Wolan
484a31d082
Add docstrings to new observation code
2023-06-01 21:28:38 +01:00
Marek Wolan
c0b214612a
Let single-component spaces not use Tuple Spaces
2023-06-01 18:01:47 +01:00
Marek Wolan
3e208bad9b
Better Obs default handling
2023-06-01 17:50:18 +01:00
Marek Wolan
7041b79d2a
Fix trying to init obs before building network
2023-06-01 17:42:35 +01:00
Marek Wolan
2b25573378
Integrate obs handler with Primaite Env
2023-06-01 16:42:10 +01:00
SunilSamra
8efa0295df
1443 - added in print test statements
2023-06-01 16:27:25 +01:00
Marek Wolan
46352ff9c2
Integrate observation handler with components
2023-06-01 13:28:40 +01:00
Marek Wolan
c904334c83
Merge branch 'feature/1463-multidiscrete-observation-option' into feature/1468-observations-class
2023-06-01 11:09:21 +01:00
Marek Wolan
3b0d05e9c9
More info in docstring
2023-06-01 11:02:10 +01:00
Marek Wolan
37d606eda6
Separate obs functions and provide docstrings
2023-06-01 10:57:11 +01:00
Marek Wolan
bfd20b7a6b
Type hint init_observations return type
2023-06-01 09:57:33 +01:00
Marek Wolan
a0960555fc
Fix docstrings to use ReST format
2023-06-01 09:54:45 +01:00
Marek Wolan
6e58c01e8d
Start creating observations module
2023-05-31 17:03:53 +01:00
SunilSamra
81e9ddca9b
1443 - reverted changes made to observation space and added config files for testing
2023-05-31 14:11:15 +01:00
SunilSamra
9a231821ea
1443 - added changes from ADSP to observation space in primaite_env.py
2023-05-31 13:15:25 +01:00
Marek Wolan
5906ed7e39
Merge remote-tracking branch 'origin/dev' into bugfix/1442-reward-ignores-red-pol
2023-05-31 11:04:00 +01:00