Chris McCarthy
e11fd2ced4
#917 - Fixed the RLlib integration
...
- Dropped support for overriding the num_episodes and num_steps at the agent level. It's just not needed and will add complexity when overriding and writing output files.
2023-06-30 16:52:57 +01:00
Chris McCarthy
7b1f889415
#917 - Integrated the PrimaiteSession into all tests.
...
- Ran a full pre-commit hook and thus encountered tons of fixes required
2023-06-30 09:08:13 +01:00
Chris McCarthy
4866722911
#917 - Overhauled transaction and mean reward writing.
...
- Separated out learning outputs from evaluation outputs
2023-06-28 16:34:00 +01:00
Chris McCarthy
edab1a393d
Merge remote-tracking branch 'origin/dev' into feature/917_Integrate_with_RLLib
...
# Conflicts:
# src/primaite/config/training_config.py
# src/primaite/main.py
2023-06-28 10:11:03 +01:00
Marek Wolan
beae1e5c4f
Cosmetic changes to satisfy pre-commit
2023-06-27 13:06:10 +01:00
Chris McCarthy
7b0f47d6f8
#917 -Finished integrating all agents to either train (policy agents) or evaluate (hard-coded agents). Still some fixing up to do, tidying up, loading etc. also docs. But this is all now working.
2023-06-20 16:06:55 +01:00
Chris McCarthy
3670f16766
#917 - Integrated both SB3 and RLlib agents into PrimaiteSession
2023-06-19 20:27:08 +01:00
Chris McCarthy
40686031e6
temp commit
2023-06-13 09:42:54 +01:00
Chris McCarthy
9563a8a121
Synced with dev
2023-06-12 16:59:31 +01:00
Chris McCarthy
fc6ec69dee
Merge remote-tracking branch 'origin/dev' into feature/915_PRI-31_Packaging_Deployment
...
# Conflicts:
# docs/source/about.rst
# src/primaite/main.py
# src/primaite/nodes/node.py
2023-06-12 16:42:26 +01:00
Chris McCarthy
4596687e35
Merge remote-tracking branch 'origin/dev' into feature/898-Fix-the-functionality-of-resetting-a-node
2023-06-12 14:20:16 +01:00
Chris McCarthy
86b813afa1
#915 - Synced with dev
2023-06-09 15:49:48 +01:00
Chris McCarthy
2fccbbd9df
Merge remote-tracking branch 'origin/dev' into feature/915_PRI-31_Packaging_Deployment
...
# Conflicts:
# docs/source/about.rst
# docs/source/config.rst
# src/primaite/common/config_values_main.py
# src/primaite/environment/primaite_env.py
# src/primaite/main.py
# tests/config/multidiscrete_obs_space_laydown_config.yaml
# tests/config/obs_tests/laydown.yaml
# tests/conftest.py
# tests/test_observation_space.py
2023-06-09 13:41:05 +01:00
Chris McCarthy
3a5d982991
#915 - Synced with dev to bring in changes from #898
2023-06-09 13:11:14 +01:00
Chris McCarthy
6c2c95b329
Merge remote-tracking branch 'origin/dev' into feature/915_PRI-31_Packaging_Deployment
...
# Conflicts:
# tests/conftest.py
# tests/test_observation_space.py
# tests/test_reward.py
2023-06-09 10:35:14 +01:00
Marek Wolan
a597cf95d7
Fix obs tests with new changes
2023-06-09 10:28:24 +01:00
Marek Wolan
00a30bcb7a
Merge remote-tracking branch 'origin/dev' into feature/1468-observations-class
2023-06-09 09:01:54 +01:00
Chris McCarthy
5558750f13
#915 - Refactored documentation and included APi docs, dependencies.
...
- make files now re-build autosummary and deps file.
- Added typer and platformdirs to deps in pyproject.toml.
- Made root_is_pure = True in setup.py as platform/python specific wheels don't need to be built but the option is there should we need to.
-
Added an e2e test for primaite.main.run func.
2023-06-08 15:57:38 +01:00
Chris McCarthy
c03dc8fd6b
# 915 - Fixed issue in conftest.py where session_path and timestamp_str were not being passed to Primaite.
...
- Also now logging all test outputs to temp directory.
2023-06-07 22:57:37 +01:00
Chris McCarthy
98fc1e4c71
#915 - Created app dirs and set as constants in the top-level init.
...
- renamed _config_values_main to training_config.py and renamed the ConfigValuesMain class to TrainingConfig.
Moved training_config.py to src/primaite/config/training_config.py
- Renamed all training config yaml file keys to make creating an instance of TrainingConfig easier.
Moved action_type and num_steps over to the training config.
- Decoupled the training config and lay down config.
- Refactored main.py so that it can be ran from CLI and can take a training config path and a lay down config path.
- refactored all outputs so that they save to the session dir.
- Added some necessary setup scripts that handle creating app dirs, fronting example config files to the user, fronting demo notebooks to the user, performing clean-up in between installations etc.
- Added functions that attempt to retrieve the file path of users example config files that have been fronted by the primaite setup.
- Added logging config and a getLogger function in the top-level init.
- Refactored all logs entries logged to use a logger using the primaite logging config.
- Added basic typer CLI for doing things like setup, viewing logs, viewing primaite version, running a basic session.
- Updated test to use new features and config structures.
- Began updating docs. More to do here.
2023-06-07 22:40:16 +01:00
Marek Wolan
4329c65211
Apply suggestions from code review.
2023-06-07 15:25:11 +01:00
SunilSamra
6089fb6950
893 - removed unnecessary functions from utils.py and changed single_action_space_fixed_blue_actions_main_config.yaml back to GENERIC agentIdentifier after PR comments
2023-06-07 14:39:52 +01:00
SunilSamra
e17e5ac4b9
893 - added new line for assert statements
2023-06-06 15:54:35 +01:00
SunilSamra
0817a4cad3
893 - added consistent action for test_reward.py
2023-06-06 13:49:22 +01:00
SunilSamra
2e1bdf2361
893 - changed action in conftest.py back to sample of the environment action space
2023-06-06 13:23:08 +01:00
SunilSamra
efd0f6ed08
893 - returned config_values in conftest to move run_generic_set_actions into test_single_action_space.py
2023-06-06 13:21:04 +01:00
SunilSamra
a45f0d1979
Merge remote-tracking branch 'origin/dev' into feature/893-node-acl-into-one-action-space
2023-06-06 11:56:52 +01:00
SunilSamra
dc7be7d8e6
893 - set the action_space to NOTHING so test_reward.py passes and removed unnecessary test print statements
2023-06-06 11:10:38 +01:00
SunilSamra
1a7d629d5a
893 - added new tests to test action space size and node is completing both sets of actions in a single episode and created new main config
2023-06-06 11:00:41 +01:00
Brian Kanyora
7432b91f53
feature\898:
2023-06-02 16:13:16 +01:00
Brian Kanyora
b3ea1938bf
Merge branch 'dev' into feature/898-Fix-the-functionality-of-resetting-a-node
2023-06-02 14:56:31 +01:00
Brian Kanyora
a1d7f9e57c
feature\898:
2023-06-02 14:54:23 +01:00
Marek Wolan
f14910ca96
Fix Link Traffic Levels observation encoding
2023-06-02 13:15:38 +01:00
Marek Wolan
73adfbb6dd
Get observation tests passing
2023-06-02 13:08:11 +01:00
Marek Wolan
14096b3dd1
Add tests for observations
2023-06-02 12:59:01 +01:00
SunilSamra
66fdae5df1
893 - added test which shows the new action space has been created when ANY is selected in single_action_space_lay_down_config.yaml
2023-06-02 11:55:31 +01:00
Marek Wolan
602bf9ba9a
Edit configs for observation space
2023-06-02 09:10:53 +01:00
Marek Wolan
16777b30ad
begin updating observations tests
2023-06-01 21:56:05 +01:00
SunilSamra
f72a80c9d2
1443 - added in print test statements
2023-06-01 16:27:25 +01:00
Marek Wolan
2b2c7ad22d
Improve observation space test
2023-06-01 09:45:46 +01:00
SunilSamra
ae2f4d472e
1443 - reverted changes made to observation space and added config files for testing
2023-05-31 14:11:15 +01:00
Marek Wolan
41910797b5
Revert config changes by removing observations
2023-05-31 10:52:57 +01:00
Marek Wolan
317549225f
Merge remote-tracking branch 'origin/dev' into feature/1463-multidiscrete-observation-option
2023-05-31 10:46:18 +01:00
SunilSamra
82371b210e
Merge remote-tracking branch 'origin/dev' into feature/893-node-acl-into-one-action-space
2023-05-31 10:34:42 +01:00
Marek Wolan
082e3b7307
Add test for new multidiscrete spaces
2023-05-30 15:48:11 +01:00
Marek Wolan
7bc938229b
Update configs and transactions to include new obs
2023-05-30 15:24:13 +01:00
SunilSamra
7aa8d89dfe
1443 - updated test_reward.py to reflect updates to reward.py so that the correct config values are called i.e. compromisedShouldBeGood on the correct steps during the training run
2023-05-30 11:50:54 +01:00
SunilSamra
3cd5864f25
1429 - created new branch from dev, added enums to enums.py, created agents package and utils.py file, added option to primaite_env.py for ANY action type and changed the action spaces are defined using ADSP branch
2023-05-26 10:17:45 +01:00
Chris McCarthy
32a4d9e459
#1355 - Carried out full renaming in node.py, active_node.py, passive_node.py, and service_node.py to make params and variable names explicit.
...
- Made the same renaming in the yaml laydown config files.
- Added Type hints wherever I've been.
- Added a custom NodeType in custom_typing.py to encompass the Union of ActiveNode, PassiveNode, ServiceNode.
2023-05-25 21:03:11 +01:00
SunilSamra
cabbe4797d
902 - changed test comment to explain the outcome of the average reward
2023-05-25 14:36:26 +01:00