Marek Wolan
c5f612889e
Merge remote-tracking branch 'origin/dev' into feature/901-change-functionality-acl-rules
2023-07-18 10:55:31 +01:00
Marek Wolan
a2ef4328dd
Remove redundant 'if TYPE_CHECKING' statements
2023-07-18 10:21:06 +01:00
Marek Wolan
3d0e50823a
Merge branch 'dev' into feature/1623-typehints
2023-07-18 10:03:48 +01:00
SunilSamra
9520cfea24
#901 - Replaced "ALLOW" with RulePermissionType.ALLOW
...
- Added Explicit ALLOW to test_configs in order for tests to work
- Added typing to access_control_list.py and acl_rule.py
2023-07-17 20:40:00 +01:00
Chris McCarthy
81295a4fc4
#1631 - Updated the copyright statement to comply with DEFCON 703 Edition 08/13
2023-07-17 19:57:34 +01:00
SunilSamra
3aab6a3738
#901 - ran black pre-commit over observations.py to fix it
2023-07-17 19:42:05 +01:00
Chris McCarthy
2d1a1e6db7
#1631 - Added the DEFCON 703 header to all possible files
2023-07-17 19:28:43 +01:00
Marek Wolan
bfce2f9a7b
Change typehints after mypy analysis
2023-07-17 16:22:07 +01:00
Sunil Samra
dd21f9440f
Apply suggestions from code review
2023-07-17 14:21:37 +00:00
SunilSamra
78d7f39342
#901 - Removed flatten from training configs
...
- Added flatten operation in observations.py when there are multiple obs components
- Updated config.rst docs
2023-07-17 13:44:16 +01:00
SunilSamra
da20c0e9e6
#901
...
- Removed bool apply_implicit_rule
- Set default implicit_rule to EXPLICIT DENY
- Added position to ACLs in laydown configs
- Removed apply_implicit_rule from training configs
2023-07-17 13:00:58 +01:00
Marek Wolan
2bb71623fa
Fix types according to mypy
2023-07-14 16:38:55 +01:00
SunilSamra
8aa71c3ff8
#901 - amended comment in observations.py
2023-07-14 16:04:13 +01:00
SunilSamra
661c865108
#901 -
...
- Added comments in access_control_list.py
- Changed obs_shape to max_number_acl_rules from max_number_acl_rules + 1 as index starts from 1
- Commented episode and step print line from test_single_action_space.py
2023-07-14 15:27:37 +01:00
SunilSamra
eb75d15722
901 - Added another test and tidied up comments in test_observation_space.py and tidied up comments in observations.py
2023-07-14 14:51:26 +01:00
SunilSamra
e743b2380c
901 - fixed test_observation_space.py, added test fixture for test_seeding_and_deterministic_session.py and increased default max number of acls
2023-07-14 12:29:50 +01:00
Marek Wolan
9650669c83
Add More Typehint
2023-07-13 18:08:44 +01:00
SunilSamra
77f717c649
Merge remote-tracking branch 'origin/dev' into feature/901-change-functionality-acl-rules
2023-07-13 16:48:02 +01:00
Marek Wolan
36e48dc8e9
Continue Adding Typehints
2023-07-13 12:25:54 +01:00
SunilSamra
0ab4dab72a
901 - fixed test_single_action_space.py test
2023-07-13 11:45:23 +01:00
SunilSamra
f8cb18c654
901 - changed acl current obs from list to numpy.array, changed default ACL list in training_config.py to FALSE, and tried to make test_seeding_and_deterministic_session.py test without fixed reward results
2023-07-13 11:04:11 +01:00
SunilSamra
06c20f6984
Merge remote-tracking branch 'origin/dev' into feature/901-change-functionality-acl-rules
...
# Conflicts:
# src/primaite/acl/access_control_list.py
2023-07-12 10:45:03 +01:00
SunilSamra
6b59ce960d
Merge remote-tracking branch 'origin/dev' into feature/1566-configure_episode-steps-learn-eval
...
# Conflicts:
# src/primaite/config/training_config.py
2023-07-11 11:39:21 +01:00
Chris McCarthy
40381833d3
#1566 - Refactored the test_train_eval_episode_steps.py to sue TempPrimaiteSession.
...
- Fixed all errors that were caused b fixing the above.
- Some tests still fail, these are for SS to fix.
- Dropped the old run_generic stuff from conftest.py
2023-07-07 15:50:14 +01:00
SunilSamra
35b481a2f3
Merge remote-tracking branch 'origin/dev' into feature/901-change-functionality-acl-rules
2023-07-07 15:14:05 +01:00
Chris McCarthy
d49f73f139
Merge remote-tracking branch 'origin/dev' into 1566-configure-episode-steps-learn-eval
...
# Conflicts:
# src/primaite/agents/rllib.py
2023-07-07 14:34:20 +01:00
SunilSamra
e03c29b921
1566 - added test file and edited configs to include types of num steps and modifed agents to use correct step and episode counts
2023-07-07 14:13:47 +01:00
Marek Wolan
7e0eee5d73
Merge remote-tracking branch 'origin/dev' into feature/1572-fix-docs-formatting
2023-07-07 10:30:11 +01:00
Marek Wolan
f4b98542b6
Standardise docstring summary line placement.
2023-07-07 10:28:00 +01:00
Marek Wolan
86725064ec
Added docstrings to class intialisers
2023-07-06 16:08:51 +01:00
Marek Wolan
c5d7d55747
Change reward to float and divide by 10000
2023-07-06 12:52:14 +01:00
SunilSamra
f651937759
901 - changed how acl rules are added to access control list and added structure to AccessControlList observation
2023-07-06 11:07:21 +01:00
SunilSamra
f121b0e21c
901 - merged with dev
2023-07-05 11:34:15 +01:00
Marek Wolan
cda9819e72
Add blank lines at the end of file.
2023-07-05 09:22:49 +01:00
SunilSamra
3f440c0a28
901 - updated observations.py to change and add new mapping of ACL rules to represent no rule present in list
2023-07-05 09:08:03 +01:00
Marek Wolan
0756e61e5d
add module level docstrings
2023-07-04 13:11:06 +01:00
Marek Wolan
d41e2ad590
Resolve remaining build warnings for docs
2023-07-04 11:34:36 +01:00
Marek Wolan
5e270c7673
Format docstrings
2023-07-04 11:11:52 +01:00
Marek Wolan
3de6208915
fix formatting on Observation docs
2023-07-04 10:57:00 +01:00
Chris McCarthy
34b294f89a
#917 - Reinstalled the pre-commit hook
2023-07-03 20:40:38 +01:00
Chris McCarthy
410d5abe12
#917 - Synced with dev and integrated the new observation space
2023-07-03 20:36:21 +01:00
Chris McCarthy
820f436f8e
Merge remote-tracking branch 'origin/dev' into feature/917_Integrate_with_RLLib
...
# Conflicts:
# src/primaite/config/_package_data/training/training_config_main.yaml
# src/primaite/environment/primaite_env.py
# src/primaite/main.py
# src/primaite/transactions/transaction.py
# src/primaite/transactions/transactions_to_file.py
2023-07-03 19:51:52 +01:00
Chris McCarthy
7816e94f83
#917 - Synced with dev (at the point of random red agent)
2023-07-03 17:25:21 +01:00
Chris McCarthy
d2764d53cc
Merge remote-tracking branch 'origin/dev' into feature/917_Integrate_with_RLLib
...
# Conflicts:
# src/primaite/config/_package_data/training/training_config_main.yaml
# src/primaite/environment/primaite_env.py
2023-07-03 15:07:09 +01:00
Marek Wolan
12c18adeb1
Merge remote-tracking branch 'origin/dev' into feature/1558-flatten-spaces
2023-07-03 15:03:10 +01:00
Czar Echavez
cb9d40579f
#1522 : create_random_red_agent -> _create_random_red_agent + converting NodeStateInstructionRed into a dataclass
2023-07-03 13:36:14 +01:00
Czar Echavez
0943e9511b
#1522 : refactor red_agent_identifier -> random_red_agent so that it is a boolean + documentation
2023-07-03 12:18:58 +01:00
Christopher McCarthy
c38c13b829
Apply suggestions from code review
2023-07-03 10:47:26 +00:00
Czar Echavez
6c4a538b41
#1522 : run pre-commit
2023-07-03 10:08:25 +01:00
Czar Echavez
4299170ce4
#1522 : added a check for existing links in laydown + test that checks if red agent instructions are random
2023-07-03 09:46:52 +01:00