oxbrbtx/PrimAITE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

3110 - remove outdated todos

Browse Source
This commit is contained in:
Marek Wolan
2025-03-12 17:13:03 +00:00
parent ea7898ce33
commit 8b91c280cb
2 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/primaite/simulator/system/services/terminal/terminal.py
View File

@@ -23,8 +23,6 @@ from primaite.utils.validation.ip_protocol import PROTOCOL_LOOKUP
from primaite.utils.validation.port import PORT_LOOKUP from primaite.utils.validation.port import PORT_LOOKUP
# TODO 2824: Since remote terminal connections and remote user sessions are the same thing, we could refactor
# the terminal to leverage the user session manager's list. This way we avoid potential bugs and code ducplication
class TerminalClientConnection(BaseModel): class TerminalClientConnection(BaseModel):
""" """
TerminalClientConnection Class. TerminalClientConnection Class.

8
tests/unit_tests/_primaite/_simulator/_network/_hardware/test_node_actions.py
View File

@@ -61,9 +61,6 @@ def test_node_os_scan(node):
"""Test OS Scanning.""" """Test OS Scanning."""
node.operating_state = NodeOperatingState.ON node.operating_state = NodeOperatingState.ON
# add process to node
# TODO implement processes
# add services to node # add services to node
node.software_manager.install(DummyService) node.software_manager.install(DummyService)
service = node.software_manager.software.get("dummy-service") service = node.software_manager.software.get("dummy-service")
@@ -95,7 +92,6 @@ def test_node_os_scan(node):
node.apply_timestep(timestep=i) node.apply_timestep(timestep=i)
# should update the state of all items # should update the state of all items
# TODO assert process.health_state_visible == SoftwareHealthState.COMPROMISED
assert service.health_state_visible == SoftwareHealthState.COMPROMISED assert service.health_state_visible == SoftwareHealthState.COMPROMISED
assert application.health_state_visible == SoftwareHealthState.COMPROMISED assert application.health_state_visible == SoftwareHealthState.COMPROMISED
assert folder.visible_health_status == FileSystemItemHealthStatus.CORRUPT assert folder.visible_health_status == FileSystemItemHealthStatus.CORRUPT
@@ -107,9 +103,6 @@ def test_node_red_scan(node):
"""Test revealing to red""" """Test revealing to red"""
node.operating_state = NodeOperatingState.ON node.operating_state = NodeOperatingState.ON
# add process to node
# TODO implement processes
# add services to node # add services to node
node.software_manager.install(DummyService) node.software_manager.install(DummyService)
service = node.software_manager.software.get("dummy-service") service = node.software_manager.software.get("dummy-service")
@@ -138,7 +131,6 @@ def test_node_red_scan(node):
node.apply_timestep(timestep=i) node.apply_timestep(timestep=i)
# should update the state of all items # should update the state of all items
# TODO assert process.revealed_to_red is True
assert service.revealed_to_red is True assert service.revealed_to_red is True
assert application.revealed_to_red is True assert application.revealed_to_red is True
assert folder.revealed_to_red is True assert folder.revealed_to_red is True