oxbrbtx/PrimAITE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove todo comments that have been completed

Browse Source
This commit is contained in:
Marek Wolan
2025-01-21 13:39:06 +00:00
parent dcce678045
commit 94ee16afa6
2 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/primaite/game/agent/observations/firewall_observation.py
View File

@@ -72,7 +72,6 @@ class FirewallObservation(AbstractObservation, identifier="FIREWALL"):
self.ports: List[PortObservation] = [ self.ports: List[PortObservation] = [
PortObservation(where=self.where + ["NICs", port_num]) for port_num in (1, 2, 3) PortObservation(where=self.where + ["NICs", port_num]) for port_num in (1, 2, 3)
] ]
# TODO: check what the port nums are for firewall.
self.internal_inbound_acl = ACLObservation( self.internal_inbound_acl = ACLObservation(
where=self.where + ["internal_inbound_acl", "acl"], where=self.where + ["internal_inbound_acl", "acl"],

2
src/primaite/simulator/system/services/terminal/terminal.py
View File

@@ -286,7 +286,6 @@ class Terminal(Service, identifier="Terminal"):
:param password: Password for login. :param password: Password for login.
:return: boolean, True if successful, else False :return: boolean, True if successful, else False
""" """
# TODO: Un-comment this when UserSessionManager is merged.
connection_uuid = self.parent.user_session_manager.local_login(username=username, password=password) connection_uuid = self.parent.user_session_manager.local_login(username=username, password=password)
if connection_uuid: if connection_uuid:
self.sys_log.info(f"{self.name}: Login request authorised, connection uuid: {connection_uuid}") self.sys_log.info(f"{self.name}: Login request authorised, connection uuid: {connection_uuid}")
@@ -413,7 +412,6 @@ class Terminal(Service, identifier="Terminal"):
if isinstance(payload, SSHPacket): if isinstance(payload, SSHPacket):
if payload.transport_message == SSHTransportMessage.SSH_MSG_USERAUTH_REQUEST: if payload.transport_message == SSHTransportMessage.SSH_MSG_USERAUTH_REQUEST:
# validate & add connection # validate & add connection
# TODO: uncomment this as part of 2781
username = payload.user_account.username username = payload.user_account.username
password = payload.user_account.password password = payload.user_account.password
connection_id = self.parent.user_session_manager.remote_login( connection_id = self.parent.user_session_manager.remote_login(